Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0

From	kgunda@codeaurora.org
Newsgroups	linux.kernel
Subject	Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0
Date	2017-07-06 12:30 +0200
Message-ID	<u0ccN-32q-13@gated-at.bofh.it> (permalink)
References	<tZ97j-1Az-11@gated-at.bofh.it> <tZ97j-1Az-9@gated-at.bofh.it> <u08VA-Sf-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-07-06 12:23, Stephen Boyd wrote:
> On 07/03, Kiran Gunda wrote:
>> From: Fenglin Wu <fenglinw@codeaurora.org>
>> 
>> The opc parameter in pmic_arb_write_cmd() function is defined with 
>> type
>> u8 and it's always greater than or equal to 0. Checking that it's not
>> less than 0 is redundant and it can cause a forbidden warning during
>> compilation. Remove the check.
>> 
>> Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
>> ---
> 
> You forgot your sign-off here.
yeah.. forgot. Will add it.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not  less than 0 Stephen Boyd <sboyd@codeaurora.org> - 2017-07-06 09:00 +0200
  Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less  than 0 kgunda@codeaurora.org - 2017-07-06 12:30 +0200

csiph-web