Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1682236

Re: [PATCH net-next] skbuff: optimize the pull_pages code in __pskb_pull_tail()

Show all headers | View raw

On Thu, 2017-07-06 at 17:01 +0800, Lin Zhang wrote:
> In the pull_pages code block, if the first frags size > eat,
> we can end the loop in advance to avoid extra copy.
> 
> Signed-off-by: Lin Zhang <xiaolou4617@gmail.com>
> ---
>  net/core/skbuff.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index f990eb8..c00a1df 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -1720,6 +1720,10 @@ void *__pskb_pull_tail(struct sk_buff *skb, int delta)
>  				skb_shinfo(skb)->frags[k].page_offset += eat;
>  				skb_frag_size_sub(&skb_shinfo(skb)->frags[k], eat);
>  				eat = 0;
> +				if (!i) {
> +					k = skb_shinfo(skb)->nr_frags;
> +					break;
> +				}
>  			}
>  			k++;
>  		}

1) net-next is closed during merge window.

2) This change is completely buggy.
   How have you tested it exactly ???

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] skbuff: optimize the pull_pages code in __pskb_pull_tail() Lin Zhang <xiaolou4617@gmail.com> - 2017-07-06 11:10 +0200
  Re: [PATCH net-next] skbuff: optimize the pull_pages code in  __pskb_pull_tail() Eric Dumazet <eric.dumazet@gmail.com> - 2017-07-06 11:20 +0200
    Re: [PATCH net-next] skbuff: optimize the pull_pages code in  __pskb_pull_tail() Eric Dumazet <eric.dumazet@gmail.com> - 2017-07-06 11:30 +0200
      Re: [PATCH net-next] skbuff: optimize the pull_pages code in __pskb_pull_tail() lin zhang <xiaolou4617@gmail.com> - 2017-07-06 11:40 +0200
        Re: [PATCH net-next] skbuff: optimize the pull_pages code in  __pskb_pull_tail() Eric Dumazet <eric.dumazet@gmail.com> - 2017-07-06 11:50 +0200

csiph-web