Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1682159

Re: [PATCH] pwm: cros-ec: fix transposed param settings

From Thierry Reding <thierry.reding@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] pwm: cros-ec: fix transposed param settings
Date 2017-07-06 10:20 +0200
Message-ID <u0ab0-1M1-25@gated-at.bofh.it> (permalink)
References <tVEMq-7yC-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, Jun 23, 2017 at 02:52:47PM -0700, Nick Vaccaro wrote:
> The __cros_ec_pwm_get_duty() routine was transposing the insize and
> outsize fields when calling cros_ec_cmd_xfer_status().
> 
> The original code worked without error due to size of the two particular
> parameter blocks passed to cros_ec_cmd_xfer_status(), so this change is
> not fixing an actual runtime problem, just correcting the calling usage.
> 
> Signed-off-by: Nick Vaccaro <nvaccaro@chromium.org>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> ---
>  drivers/pwm/pwm-cros-ec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] pwm: cros-ec: fix transposed param settings Thierry Reding <thierry.reding@gmail.com> - 2017-07-06 10:20 +0200

csiph-web