Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1683588

Re: [PATCH 0/3] Motorola Droid 4 Audio Support

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Fri, Jul 07, 2017 at 10:27:53PM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170707 09:43]:
> > I got working sound on Droid 4 with mainline \o/. The codec is
> > currently missing support for detecting if something has been
> > plugged into the 3.5mm connector, since that seems to require
> > some closed source firmware and needs further investigation. I
> > think this can be added later.
> 
> Hey that's great! I'll give it a try this weekend.. Does that mean
> that 3G voice calls work too now or is something more needed there?

I added some text about that in the 3rd patch. Basically the codec driver
is ready (maybe a few quirks will be needed, though), but the soundcard
driver is not. It currently assumes CPU <-> Voice Codec, but
actually its a network of CPU, Voice Codec, Modem(s?) and Bluetooth.

> For the CPCAP PMIC macro interrupts I think it's best to set up
> a separate driver as it seems separate from the core CPCAP
> functionality. So I think we can just move the unused "cpcap-m2"
> IRQ banks out of motorola-cpcap.c and put them into a separate child
> driver that loads it's firmware on init and provides interrupts for
> the 3.5mm connector.

I also think the macro block fw handling should not be handled in
the driver for the audio codec. IIRC it is also used to provide a
blink feature for the status LEDs. OTOH some of the registers of the
audio-codec are also used for 3.5mm detection. I also did not yet look
into the details of this one.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Motorola Droid 4 Audio Support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-07 18:50 +0200
  [PATCH 3/3] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-07 18:50 +0200
    Re: [PATCH 3/3] ARM: dts: omap4-droid4: add soundcard Mark Brown <broonie@kernel.org> - 2017-07-10 14:30 +0200
  Re: [PATCH 0/3] Motorola Droid 4 Audio Support Tony Lindgren <tony@atomide.com> - 2017-07-08 07:30 +0200
    Re: [PATCH 0/3] Motorola Droid 4 Audio Support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-08 13:40 +0200
      Re: [PATCH 0/3] Motorola Droid 4 Audio Support Tony Lindgren <tony@atomide.com> - 2017-07-09 07:40 +0200
  Re: [PATCH 1/3] ASoC: codec: cpcap: new codec Tony Lindgren <tony@atomide.com> - 2017-07-09 07:40 +0200
  Re: [PATCH 1/3] ASoC: codec: cpcap: new codec Rob Herring <robh@kernel.org> - 2017-07-10 17:30 +0200
  Re: [PATCH 1/3] ASoC: codec: cpcap: new codec Mark Brown <broonie@kernel.org> - 2017-07-10 20:00 +0200
    Re: [PATCH 1/3] ASoC: codec: cpcap: new codec Tony Lindgren <tony@atomide.com> - 2017-07-11 07:20 +0200
      Re: [PATCH 1/3] ASoC: codec: cpcap: new codec Mark Brown <broonie@kernel.org> - 2017-07-11 12:50 +0200
        Re: [PATCH 1/3] ASoC: codec: cpcap: new codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-11 14:20 +0200
          Re: [PATCH 1/3] ASoC: codec: cpcap: new codec Mark Brown <broonie@kernel.org> - 2017-07-11 15:40 +0200

csiph-web