Re: irq: Invalid fwnode type (2) for irqdomain

From	Marc Zyngier <marc.zyngier@arm.com>
Newsgroups	linux.kernel
Subject	Re: irq: Invalid fwnode type (2) for irqdomain
Date	2017-07-08 11:50 +0200
Message-ID	<u0Uxb-v4-3@gated-at.bofh.it> (permalink)
References	<tZPSX-537-27@gated-at.bofh.it> <tZQ2B-56s-11@gated-at.bofh.it> <u0fX5-5RS-17@gated-at.bofh.it> <u0SlH-7Gr-3@gated-at.bofh.it>
Organization	ARM Ltd

Show all headers | View raw

On Sat, Jul 08 2017 at  9:28:17 am BST, Paul Menzel <pmenzel@molgen.mpg.de> wrote:

Hi Paul,


>> I've been reported an issue that is somewhat related to this, Any
>> chance you could give this[1] a go? I have no way to test it...
>
> The commit below indeed made the warning go away.
>
>> commit 6bf31c05f2a967e5351a3050ef51c18c8c9ee291
>> Author: Marc Zyngier <marc.zyngier@arm.com>
>> Date:   Thu Jul 6 14:51:31 2017 +0100
>> 
>>     irqdomain: Allow ACPI device nodes to be used as irqdomain identifiers
>>     
>>     A number of irqchip implementations are (ab)using the irqdomain
>>     allocator by passing a fwnode that is neither a FWNODE_OF or
>>     a FWNODE_IRQCHIP.
>>     
>>     This is pretty bad, but it also feels pretty crap to force these
>>     drivers to allocate their own irqchip_fwid when they already have
>>     a proper fwnode.
>>     
>>     Instead, let's teach the irqdomain allocator about ACPI device
>>     nodes, and add some lovely name generation code... Tested on
>>     an arm64 D05 system.
>>     
>>     Reported-by: John Garry <john.garry@huawei.com>
>>     Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>
> I wonder if a warning/debug messages could and should still be shown,
> if a fwnode is neither a FWNODE_OF or a FWNODE_IRQCHIP.

With this patch, the code covers FWNODE_OF, FWNODE_IRQCHIP and
FWNODE_ACPI (the latter being the case you and John uncovered). Should
we get any other fwnode_type value, the irqdomain code will still warn
the user that this is not an object type we're ready to accept.

Thanks again for the report and the testing.

	M.
-- 
Jazz is not dead. It just smells funny.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

irq: Invalid fwnode type (2) for irqdomain Paul Menzel <pmenzel@molgen.mpg.de> - 2017-07-05 12:40 +0200
  Re: irq: Invalid fwnode type (2) for irqdomain Thomas Gleixner <tglx@linutronix.de> - 2017-07-05 12:50 +0200
    Re: irq: Invalid fwnode type (2) for irqdomain Marc Zyngier <marc.zyngier@arm.com> - 2017-07-06 16:30 +0200
      Re: irq: Invalid fwnode type (2) for irqdomain Paul Menzel <pmenzel@molgen.mpg.de> - 2017-07-08 09:30 +0200
        Re: irq: Invalid fwnode type (2) for irqdomain Marc Zyngier <marc.zyngier@arm.com> - 2017-07-08 11:50 +0200

csiph-web