Re: [Xen-devel] maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [Xen-devel] maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"
Date	Sat, 08 Jul 2017 03:10:01 +0200
Message-ID	<u0MpX-3OG-1@gated-at.bofh.it> (permalink)
References	<to0w1-3Qh-17@gated-at.bofh.it> <toEa5-6Td-13@gated-at.bofh.it> <toEMN-7q1-15@gated-at.bofh.it> <toEWt-7xX-5@gated-at.bofh.it> <toIQp-1P9-1@gated-at.bofh.it> <tpIY2-4JX-15@gated-at.bofh.it> <tpOAq-iy-5@gated-at.bofh.it> <tpUmu-4GO-23@gated-at.bofh.it> <tq0rT-vR-5@gated-at.bofh.it> <tq1nY-1do-9@gated-at.bofh.it>
X-Original-To	Juergen Gross <jgross@suse.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.8.0 (2017-02-23)
X-Source-IP	aserv0022.oracle.com [141.146.126.234]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	Boris Ostrovsky <boris.ostrovsky@oracle.com>, Jan Beulich <JBeulich@suse.com>, Dan Streetman <dan.streetman@canonical.com>, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 7 Jul 2017 20:59:58 -0400
X-Original-Message-ID	<20170708005958.GA30785@char.us.oracle.com>
X-Original-References	<0628e2af-f7e7-056a-82ec-68860f9c4f29@oracle.com> <CAOZ2QJPgbTibTX+3sO1FQou_mNX-CDd0PQUbWehEEgAGVcnYMg@mail.gmail.com> <20170324211016.GG9755@char.us.oracle.com> <CAOZ2QJNq_oHsk=HcK3wc-DLt78sTRydUw2VYx-A0vLbJ64bGNQ@mail.gmail.com> <c7cbd3c7-5785-a3cc-ca28-a289ebe1cb4f@oracle.com> <CAOZ2QJMkqY556qXkdgFpFpir381dJTuPKex+SjdnH43sspkkWw@mail.gmail.com> <9b134234-5b38-c325-b3c2-f37b4c45c2cf@oracle.com> <58DA361E0200007800148E16@prv-mh.provo.novell.com> <2288a326-752e-85a5-d986-62c86b91e249@oracle.com> <e00ee5aa-48b9-57f0-0511-9e08057a7045@suse.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1683495

Show key headers only | View raw

On Tue, Mar 28, 2017 at 05:30:24PM +0200, Juergen Gross wrote:
> On 28/03/17 16:27, Boris Ostrovsky wrote:
> > On 03/28/2017 04:08 AM, Jan Beulich wrote:
> >>>>> On 28.03.17 at 03:57, <boris.ostrovsky@oracle.com> wrote:
> >>> I think there is indeed a disconnect between target memory (provided by 
> >>> the toolstack) and current memory (i.e actual pages available to the guest).
> >>>
> >>> For example
> >>>
> >>> [    0.000000] BIOS-e820: [mem 0x000000000009e000-0x000000000009ffff] 
> >>> reserved
> >>> [    0.000000] BIOS-e820: [mem 0x00000000000e0000-0x00000000000fffff] 
> >>> reserved
> >>>
> >>> are missed in target calculation. The hvmloader marks them as RESERVED 
> >>> (in build_e820_table()) but target value is not aware of this action.
> >>>
> >>> And then the same problem repeats when kernel removes 
> >>> 0x000a0000-0x000fffff chunk.
> >> But this is all in-guest behavior, i.e. nothing an entity outside the
> >> guest (tool stack or hypervisor) should need to be aware of. That
> >> said, there is still room for improvement in the tools I think:
> >> Regions which architecturally aren't RAM (namely the
> >> 0xa0000-0xfffff range) would probably better not be accounted
> >> for as RAM as far as ballooning is concerned. In the hypervisor,
> >> otoh, all memory assigned to the guest (i.e. including such backing
> >> ROMs) needs to be accounted.
> > 
> > On the Linux side we should not include in balloon calculations pages
> > reserved by trim_bios_range(), i.e. (BIOS_END-BIOS_BEGIN) + 1.
> > 
> > Which leaves hvmloader's special pages (and possibly memory under
> > 0xA0000 which may get reserved). Can we pass this info to guests via
> > xenstore?
> 
> I'd rather keep an internal difference between online pages and E820-map
> count value in the balloon driver. This should work always.

Did we ever come with a patch for this?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [Xen-devel] maybe revert commit c275a57f5ec3 "xen/balloon: Set  balloon's initial state to number of existing RAM pages" Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2017-07-08 03:10 +0200
  Re: [Xen-devel] maybe revert commit c275a57f5ec3 "xen/balloon: Set  balloon's initial state to number of existing RAM pages" Juergen Gross <jgross@suse.com> - 2017-07-09 15:20 +0200

csiph-web