Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread be SCHED_DEADLINE

From	Joel Fernandes <joelaf@google.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread be SCHED_DEADLINE
Date	2017-07-08 01:00 +0200
Message-ID	<u0Ko9-2b0-1@gated-at.bofh.it> (permalink)
References	(2 earlier) <u0z9o-2TL-9@gated-at.bofh.it> <u0BkR-4wI-9@gated-at.bofh.it> <u0Js6-1yk-7@gated-at.bofh.it> <u0JBL-1Ss-17@gated-at.bofh.it> <u0JLr-1Wo-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 7, 2017 at 3:15 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 7 Jul 2017 15:07:09 -0700
> Joel Fernandes <joelaf@google.com> wrote:
>
>
>> > It is rather long. Although I actually hate the SUGOV, it is easily
>> > grepable. Just comment what it stands for. We can always change it
>> > later.
>>
>> I was thinking why not just SCHED_FLAG_CPUFREQ. That says its for
>> cpufreq purposes, and is a bit self-documenting. "WORKER" is a bit
>> redundant and can be dropped in my opinion.
>
> I was thinking that too, but was wondering how tightly coupled is this
> with SCHED_DEADLINE? I like the searchability of SUGOV, where as
> CPUFREQ is still quite broad.

Yes this is tightly coupled with DL so in that case probably a more
specific name is better as you mentioned.

thanks,

-Joel

Thread

[RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread be SCHED_DEADLINE Juri Lelli <juri.lelli@arm.com> - 2017-07-05 11:10 +0200
  Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Joel Fernandes <joelaf@google.com> - 2017-07-07 06:00 +0200
    Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Thomas Gleixner <tglx@linutronix.de> - 2017-07-07 12:50 +0200
      Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Juri Lelli <juri.lelli@arm.com> - 2017-07-07 13:00 +0200
        Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread be SCHED_DEADLINE "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-07 15:20 +0200
          Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Steven Rostedt <rostedt@goodmis.org> - 2017-07-08 00:00 +0200
            Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Joel Fernandes <joelaf@google.com> - 2017-07-08 00:10 +0200
              Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Steven Rostedt <rostedt@goodmis.org> - 2017-07-08 00:20 +0200
                Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Joel Fernandes <joelaf@google.com> - 2017-07-08 01:00 +0200
    Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Juri Lelli <juri.lelli@arm.com> - 2017-07-07 12:50 +0200
    Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Peter Zijlstra <peterz@infradead.org> - 2017-07-11 14:40 +0200
  Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-07 09:30 +0200
  Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Peter Zijlstra <peterz@infradead.org> - 2017-07-11 18:20 +0200
    Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread  be SCHED_DEADLINE Juri Lelli <juri.lelli@arm.com> - 2017-07-11 19:10 +0200

csiph-web