[PATCH v2 1/1] mux: mux-core: Add NULL check for dev->of_node

From	sathyanarayanan.kuppuswamy@linux.intel.com
Newsgroups	linux.kernel
Subject	[PATCH v2 1/1] mux: mux-core: Add NULL check for dev->of_node
Date	2017-07-07 23:50 +0200
Message-ID	<u0Jiq-1sx-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

If dev->of_node is NULL, then calling mux_control_get()
function can lead to NULL pointer exception. So adding
a NULL check for dev->of_node.

Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
 drivers/mux/mux-core.c | 3 +++
 1 file changed, 3 insertions(+)

Changes since v1:
 * Removed dummy new line.

diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c
index 90b8995..924c983 100644
--- a/drivers/mux/mux-core.c
+++ b/drivers/mux/mux-core.c
@@ -438,6 +438,9 @@ struct mux_control *mux_control_get(struct device *dev, const char *mux_name)
 	int index = 0;
 	int ret;
 
+	if (!np)
+		return ERR_PTR(-ENODEV);
+
 	if (mux_name) {
 		index = of_property_match_string(np, "mux-control-names",
 						 mux_name);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/1] mux: mux-core: Add NULL check for dev->of_node sathyanarayanan.kuppuswamy@linux.intel.com - 2017-07-07 23:50 +0200
  Re: [PATCH v2 1/1] mux: mux-core: Add NULL check for dev->of_node "Kuppuswamy, Sathyanarayanan" <sathyaosid@gmail.com> - 2017-07-09 01:20 +0200
    Re: [PATCH v2 1/1] mux: mux-core: Add NULL check for dev->of_node "Kuppuswamy, Sathyanarayanan" <sathyaosid@gmail.com> - 2017-07-09 09:40 +0200
      Re: [PATCH v2 1/1] mux: mux-core: Add NULL check for dev->of_node sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-07-10 23:40 +0200

csiph-web