Re: [PATCH 2/8] usb: bdc: Add Device Tree binding document for Broadcom BDC driver

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/8] usb: bdc: Add Device Tree binding document for Broadcom BDC driver
Date	2017-07-07 22:20 +0200
Message-ID	<u0HTj-yy-7@gated-at.bofh.it> (permalink)
References	<tX3pn-4kt-5@gated-at.bofh.it> <tX3po-4kt-39@gated-at.bofh.it> <u0fNo-5Im-9@gated-at.bofh.it> <u0HTj-yy-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Please only post plain text emails.

On Fri, Jul 7, 2017 at 2:03 PM, Al Cooper <al.cooper@broadcom.com> wrote:
>
>
> On Thu, Jul 6, 2017 at 10:18 AM, Rob Herring <robh@kernel.org> wrote:
>>
>> On Tue, Jun 27, 2017 at 02:23:20PM -0400, Al Cooper wrote:
>> > Add Device Tree binding document for Broadcom USB Device
>> > Controller (BDC).
>> >
>> > Signed-off-by: Al Cooper <alcooperx@gmail.com>
>> > ---
>> >  .../devicetree/bindings/usb/brcm,bdc-udc.txt       | 28 ++++++++++++++++++++++
>> >  1 file changed, 28 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/usb/brcm,bdc-udc.txt
>> >
>> > diff --git a/Documentation/devicetree/bindings/usb/brcm,bdc-udc.txt b/Documentation/devicetree/bindings/usb/brcm,bdc-udc.txt
>> > new file mode 100644
>> > index 0000000..4eeaddb
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/usb/brcm,bdc-udc.txt
>> > @@ -0,0 +1,28 @@
>> > +Broadcom USB Device Controller (BDC)
>> > +====================================
>> > +
>> > +Required properties:
>> > +
>> > +- compatible: must be one of:
>> > +                "brcm,bdc-udc-v0.16"
>> > +                "brcm,bdc-udc"
>>
>> Isn't "bdc-udc" redundant?
>
>
> I'll change the base name to "brcm-udc"

Well, it should be "brcm,<something>" with the vendor prefix followed
by a comma. If the block is known as the BDC, then I'd use that.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/8] usb: bdc: Add Device Tree binding document for  Broadcom BDC driver Rob Herring <robh@kernel.org> - 2017-07-06 16:20 +0200
  Re: [PATCH 2/8] usb: bdc: Add Device Tree binding document for  Broadcom BDC driver Rob Herring <robh@kernel.org> - 2017-07-07 22:20 +0200

csiph-web