Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1683373

[PATCH 2/2] lightnvm: pblk: remove unnecessary checks

From "Javier González" <jg@lightnvm.io>
Newsgroups linux.kernel
Subject [PATCH 2/2] lightnvm: pblk: remove unnecessary checks
Date 2017-07-07 21:10 +0200
Message-ID <u0GNz-8jW-9@gated-at.bofh.it> (permalink)
References <u0GNz-8jW-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Remove unnecessary checks when freeing dma memory in the completion
path.

Signed-off-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <matias@cnexlabs.com>
---
 drivers/lightnvm/pblk-write.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/lightnvm/pblk-write.c b/drivers/lightnvm/pblk-write.c
index cc2b9414d17c..3ad9e56d2473 100644
--- a/drivers/lightnvm/pblk-write.c
+++ b/drivers/lightnvm/pblk-write.c
@@ -39,9 +39,7 @@ static unsigned long pblk_end_w_bio(struct pblk *pblk, struct nvm_rq *rqd,
 
 	ret = pblk_rb_sync_advance(&pblk->rwb, c_ctx->nr_valid);
 
-	if (rqd->meta_list)
-		nvm_dev_dma_free(dev->parent, rqd->meta_list,
-							rqd->dma_meta_list);
+	nvm_dev_dma_free(dev->parent, rqd->meta_list, rqd->dma_meta_list);
 
 	bio_put(rqd->bio);
 	pblk_free_rqd(pblk, rqd, WRITE);
@@ -224,9 +222,6 @@ static int pblk_alloc_w_rq(struct pblk *pblk, struct nvm_rq *rqd,
 	if (!rqd->meta_list)
 		return -ENOMEM;
 
-	if (unlikely(nr_secs == 1))
-		return 0;
-
 	rqd->ppa_list = rqd->meta_list + pblk_dma_meta_size;
 	rqd->dma_ppa_list = rqd->dma_meta_list + pblk_dma_meta_size;
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] LightNVM: Fixes for 4.13 "Javier González" <jg@lightnvm.io> - 2017-07-07 21:10 +0200
  [PATCH 2/2] lightnvm: pblk: remove unnecessary checks "Javier González" <jg@lightnvm.io> - 2017-07-07 21:10 +0200
  [PATCH 1/2] lightnvm: pblk: control I/O flow also on tear down "Javier González" <jg@lightnvm.io> - 2017-07-07 21:10 +0200

csiph-web