Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1683307

Re: Problem with commit bf22ff45bed664aefb5c4e43029057a199b7070c

Show all headers | View raw

On Fri, 7 Jul 2017, Juergen Gross wrote:

> Commit bf22ff45bed664aefb5c4e43029057a199b7070c ("genirq: Avoid
> unnecessary low level irq function calls") breaks Xen guest
> save/restore handling.
> 
> The main problem are the PV devices using Xen event channels as
> interrupt sources which are represented as an "irq chip" in the kernel.
> When saving the guest the event channels are masked internally. At
> restore time event channels are re-established and unmasked via
> irq_startup(). Unfortunately above commit will let the unmask operation
> be a nop as the irq handling doesn't know about the masking done before.

Rightfully so. Making assumptions about the inner workings of core code is
always wrong.

> I have a patch repairing the issue, but I'm not sure if this way to do
> it would be accepted. I have exported mask_irq() and I'm doing the
> masking now through this function. Would the attached patch be
> acceptable? Or is there a better way to solve the problem?

Without looking at the patch (too lazy to fiddle with attachments right
now), this is definitely wrong. I'll have a look later tonight.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Problem with commit bf22ff45bed664aefb5c4e43029057a199b7070c Juergen Gross <jgross@suse.com> - 2017-07-07 17:00 +0200
  Re: Problem with commit bf22ff45bed664aefb5c4e43029057a199b7070c Thomas Gleixner <tglx@linutronix.de> - 2017-07-07 18:50 +0200
    Re: Problem with commit bf22ff45bed664aefb5c4e43029057a199b7070c Juergen Gross <jgross@suse.com> - 2017-07-07 19:10 +0200
    Re: Problem with commit bf22ff45bed664aefb5c4e43029057a199b7070c Thomas Gleixner <tglx@linutronix.de> - 2017-07-07 19:20 +0200
      Re: Problem with commit bf22ff45bed664aefb5c4e43029057a199b7070c Juergen Gross <jgross@suse.com> - 2017-07-10 09:30 +0200
        Re: Problem with commit bf22ff45bed664aefb5c4e43029057a199b7070c Thomas Gleixner <tglx@linutronix.de> - 2017-07-12 17:40 +0200
          Re: Problem with commit bf22ff45bed664aefb5c4e43029057a199b7070c Thomas Gleixner <tglx@linutronix.de> - 2017-07-12 22:30 +0200
  Re: Problem with commit bf22ff45bed664aefb5c4e43029057a199b7070c Marc Zyngier <marc.zyngier@arm.com> - 2017-07-07 19:20 +0200

csiph-web