Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1683287
| From | Wim ten Have <wim.ten.have@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2] PCI: Do not enable extended tags on pre-dated (v1.x) systems |
| Date | 2017-07-07 18:20 +0200 |
| Message-ID | <u0E95-6rS-35@gated-at.bofh.it> (permalink) |
| References | <u0CTE-5qc-13@gated-at.bofh.it> <u0D3j-5J4-15@gated-at.bofh.it> |
| Organization | Oracle Corporation |
On Fri, 7 Jul 2017 11:01:16 -0400
Sinan Kaya <okaya@codeaurora.org> wrote:
> Hi Wim,
>
> On 7/7/2017 10:53 AM, Sinan Kaya wrote:
> > According to extended tags ECN document, all PCIe receivers are expected
> > to support extended tags support. It should be safe to enable extended
> > tags on endpoints without checking compatibility.
> >
> > This assumption seems to be working fine except for the legacy systems.
> > The ECN has been written against PCIE spec version 2.0. Therefore, we need
> > to exclude all version 1.0 devices from this change as there is HW out
> > there that can't handle extended tags.
> >
> > Note that the default value of Extended Tags Enable bit is implementation
> > specific. Therefore, we are clearing the bit by default when incompatible
> > HW is found without assuming that value is zero.
> >
> > Reported-by: Wim ten Have <wim.ten.have@oracle.com>
> > Link: https://pcisig.com/sites/default/files/specification_documents/ECN_Extended_Tag_Enable_Default_05Sept2008_final.pdf
> > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1467674
> > Fixes: 60db3a4d8cc9 ("PCI: Enable PCIe Extended Tags if supported")
> > Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> > ---
>
> Can you also give this a spin? I don't have a system with v1 PCIe bridges.
> I only tested v2 and later code path.
>
> I tried to address Jike Song concerns on this version and removed your tested-by
> since the code changed.
>
> Sinan
>
Sure,
--
Wim ten Have | Consulting Member of Technical Staff
Oracle Linux and VM Development Engineering
ORACLE Nederland BV | Hertogswetering 163-167 | 3543 AS Utrecht/NL
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2] PCI: Do not enable extended tags on pre-dated (v1.x) systems Sinan Kaya <okaya@codeaurora.org> - 2017-07-07 17:00 +0200
Re: [PATCH V2] PCI: Do not enable extended tags on pre-dated (v1.x) systems Sinan Kaya <okaya@codeaurora.org> - 2017-07-07 17:10 +0200
Re: [PATCH V2] PCI: Do not enable extended tags on pre-dated (v1.x) systems Sinan Kaya <okaya@codeaurora.org> - 2017-07-07 17:30 +0200
Re: [PATCH V2] PCI: Do not enable extended tags on pre-dated (v1.x) systems Sinan Kaya <okaya@codeaurora.org> - 2017-07-07 17:10 +0200
Re: [PATCH V2] PCI: Do not enable extended tags on pre-dated (v1.x) systems Wim ten Have <wim.ten.have@oracle.com> - 2017-07-07 18:20 +0200
Re: [PATCH V2] PCI: Do not enable extended tags on pre-dated (v1.x) systems Bjorn Helgaas <helgaas@kernel.org> - 2017-07-11 01:10 +0200
Re: [PATCH V2] PCI: Do not enable extended tags on pre-dated (v1.x) systems Sinan Kaya <okaya@codeaurora.org> - 2017-07-11 02:30 +0200
Re: [PATCH V2] PCI: Do not enable extended tags on pre-dated (v1.x) systems Sinan Kaya <okaya@codeaurora.org> - 2017-07-11 03:50 +0200
csiph-web