Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1682107

Re: [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@gmail.com>

Show all headers | View raw

On Thu, Jul 6, 2017 at 3:22 AM, yash007 <yashomer0007@gmail.com> wrote:
> From: Yash Omer <yash007@boss>

Your commit message is completely broken. Please fix it. See
Documentation/process/submitting-patches.rst chapter 14.

>
> ---
>  drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 1943e66..0034ebe 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -1230,7 +1230,7 @@ static void neo_flush_uart_write(struct channel_t *ch)
>                  */
>                 tmp = readb(&ch->ch_neo_uart->isr_fcr);
>                 if (tmp & 4)
> -                       udelay(10);
> +                       usleep_range(10);
>                 else
>                         break;
>         }
> @@ -1261,7 +1261,7 @@ static void neo_flush_uart_read(struct channel_t *ch)
>                  */
>                 tmp = readb(&ch->ch_neo_uart->isr_fcr);
>                 if (tmp & 2)
> -                       udelay(10);
> +                       usleep_range(10);
>                 else
>                         break;
>         }
> @@ -1483,7 +1483,7 @@ static void neo_assert_modem_signals(struct channel_t *ch)
>         neo_pci_posting_flush(ch->ch_bd);
>
>         /* Give time for the UART to actually raise/drop the signals */
> -       udelay(10);
> +       usleep_range(10);
>  }
>
>  static void neo_send_start_character(struct channel_t *ch)
> @@ -1495,7 +1495,7 @@ static void neo_send_start_character(struct channel_t *ch)
>                 ch->ch_xon_sends++;
>                 writeb(ch->ch_startc, &ch->ch_neo_uart->txrx);
>                 neo_pci_posting_flush(ch->ch_bd);
> -               udelay(10);
> +               usleep_range(10);
>         }
>  }
>
> @@ -1508,7 +1508,7 @@ static void neo_send_stop_character(struct channel_t *ch)
>                 ch->ch_xoff_sends++;
>                 writeb(ch->ch_stopc, &ch->ch_neo_uart->txrx);
>                 neo_pci_posting_flush(ch->ch_bd);
> -               udelay(10);
> +               usleep_range(10);
>         }
>  }
>
> --
> 2.1.4
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@gmail.com> yash007 <yashomer0007@gmail.com> - 2017-07-06 09:00 +0200
  Re: [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c  This is a patch to the dgnc_neo.c warning udealy to usleep range  Signed-off-by: Yash Omer <yashomer0007@gmail.com> Frans Klaver <fransklaver@gmail.com> - 2017-07-06 09:20 +0200

csiph-web