Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1682111

Re: [PATCH v5 2/3] mfd: dln2: Add cell for initializing DLN2 ADC

Show all headers | View raw

On Wed, 05 Jul 2017, Jack Andersen wrote:

> Signed-off-by: Jack Andersen <jackoalan@gmail.com>
> ---
>  drivers/mfd/dln2.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

Patch looks fine, but you need a commit message.

Once you have one, you may apply my:

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c
> index 704e189..a22ab8c 100644
> --- a/drivers/mfd/dln2.c
> +++ b/drivers/mfd/dln2.c
> @@ -53,6 +53,7 @@ enum dln2_handle {
>  	DLN2_HANDLE_GPIO,
>  	DLN2_HANDLE_I2C,
>  	DLN2_HANDLE_SPI,
> +	DLN2_HANDLE_ADC,
>  	DLN2_HANDLES
>  };
>  
> @@ -663,6 +664,12 @@ static int dln2_start_rx_urbs(struct dln2_dev *dln2, gfp_t gfp)
>  	.port = 0,
>  };
>  
> +/* Only one ADC port supported */
> +static struct dln2_platform_data dln2_pdata_adc = {
> +	.handle = DLN2_HANDLE_ADC,
> +	.port = 0,
> +};
> +
>  static const struct mfd_cell dln2_devs[] = {
>  	{
>  		.name = "dln2-gpio",
> @@ -679,6 +686,11 @@ static int dln2_start_rx_urbs(struct dln2_dev *dln2, gfp_t gfp)
>  		.platform_data = &dln2_pdata_spi,
>  		.pdata_size = sizeof(struct dln2_platform_data),
>  	},
> +	{
> +		.name = "dln2-adc",
> +		.platform_data = &dln2_pdata_adc,
> +		.pdata_size = sizeof(struct dln2_platform_data),
> +	},
>  };
>  
>  static void dln2_stop(struct dln2_dev *dln2)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 1/3] iio: adc: Add support for DLN2 ADC Jack Andersen <jackoalan@gmail.com> - 2017-07-05 23:20 +0200
  [PATCH v5 2/3] mfd: dln2: Add cell for initializing DLN2 ADC Jack Andersen <jackoalan@gmail.com> - 2017-07-05 23:20 +0200
    Re: [PATCH v5 2/3] mfd: dln2: Add cell for initializing DLN2 ADC Lee Jones <lee.jones@linaro.org> - 2017-07-06 09:20 +0200
  [PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails Jack Andersen <jackoalan@gmail.com> - 2017-07-05 23:20 +0200
    Re: [PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails Jack Andersen <jackoalan@gmail.com> - 2017-07-05 23:30 +0200
      Re: [PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails Lee Jones <lee.jones@linaro.org> - 2017-07-06 09:10 +0200
        Re: [PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails Jack Andersen <jackoalan@gmail.com> - 2017-07-06 23:10 +0200
  Re: [PATCH v5 1/3] iio: adc: Add support for DLN2 ADC Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2017-07-06 13:40 +0200

csiph-web