Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1682136

Re: [tip:locking/urgent] locking/rwsem-spinlock: Fix EINTR branch in __down_write_common()

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [tip:locking/urgent] locking/rwsem-spinlock: Fix EINTR branch in __down_write_common()
Date 2017-07-06 09:50 +0200
Message-ID <u09HX-1nl-9@gated-at.bofh.it> (permalink)
References <tXlcB-7iY-7@gated-at.bofh.it> <tZTDc-7v9-19@gated-at.bofh.it> <tZTMR-7yB-1@gated-at.bofh.it> <u09oD-1hk-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Jul 06, 2017 at 09:28:58AM +0200, Ingo Molnar wrote:
> It's more straightforward to just do the canonical sem->count >= 0 test that we do 
> elsewhere in the rwsem-spinlock code.
> 
> PeterZ, what's your preference?

Leave it as is.. it doesn't matter (the 0 case shouldn't happen) and as
you say >= 0 is what most other code does.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[tip:locking/urgent] locking/rwsem-spinlock: Fix EINTR branch in  __down_write_common() tip-bot for Kirill Tkhai <tipbot@zytor.com> - 2017-07-05 16:40 +0200
  Re: [tip:locking/urgent] locking/rwsem-spinlock: Fix EINTR branch in  __down_write_common() Niklas Cassel <niklas.cassel@axis.com> - 2017-07-05 16:50 +0200
    Re: [tip:locking/urgent] locking/rwsem-spinlock: Fix EINTR branch in  __down_write_common() Ingo Molnar <mingo@kernel.org> - 2017-07-06 09:30 +0200
      Re: [tip:locking/urgent] locking/rwsem-spinlock: Fix EINTR branch in  __down_write_common() Peter Zijlstra <peterz@infradead.org> - 2017-07-06 09:50 +0200

csiph-web