Groups > linux.kernel > #1682006

[PATCH net V2 1/2] net: hns: Fix a wrong op phy C45 code

From	Lin Yun Sheng <linyunsheng@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH net V2 1/2] net: hns: Fix a wrong op phy C45 code
Date	2017-07-06 04:00 +0200
Message-ID	<u04ff-60x-3@gated-at.bofh.it> (permalink)
References	<u04fg-60x-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Yunsheng Lin <linyunsheng@huawei.com>

As the user manual described, the second step to write to C45 phy
by mdio should be data, but not address. Here we should fix this
issue.

Fixes: 5b904d39406a ("net: add Hisilicon Network Subsystem MDIO support")
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Reviewed-by: lipeng <lipeng321@huawei.com>
---
 drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c
index e5221d9..017e084 100644
--- a/drivers/net/ethernet/hisilicon/hns_mdio.c
+++ b/drivers/net/ethernet/hisilicon/hns_mdio.c
@@ -261,7 +261,7 @@ static int hns_mdio_write(struct mii_bus *bus,
 
 		/* config the data needed writing */
 		cmd_reg_cfg = devad;
-		op = MDIO_C45_WRITE_ADDR;
+		op = MDIO_C45_WRITE_DATA;
 	}
 
 	MDIO_SET_REG_FIELD(mdio_dev, MDIO_WDATA_REG, MDIO_WDATA_DATA_M,
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH net V2 1/2] net: hns: Fix a wrong op phy C45 code Lin Yun Sheng <linyunsheng@huawei.com> - 2017-07-06 04:00 +0200

csiph-web