Groups > linux.kernel > #1682004

RE: Re: [PATCH] PM / devfreq: constify attribute_group structures.

From	MyungJoo Ham <myungjoo.ham@samsung.com>
Newsgroups	linux.kernel
Subject	RE: Re: [PATCH] PM / devfreq: constify attribute_group structures.
Date	2017-07-06 03:50 +0200
Message-ID	<u045B-5Wp-33@gated-at.bofh.it> (permalink)
References	<tZ6Cu-8lE-11@gated-at.bofh.it> <tZ6Cu-8lE-15@gated-at.bofh.it> <u045B-5Wp-35@gated-at.bofh.it> <tZ6Cu-8lE-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On 2017년 07월 03일 19:10, Arvind Yadav wrote:
> > attribute_groups are not supposed to change at runtime. All functions
> > working with attribute_groups provided by <linux/sysfs.h> work with const
> > attribute_group. So mark the non-const structs as const.
> > 
> > File size before:
> >    text	   data	    bss	    dec	    hex	filename
> >     621	    176	      0	    797	    31d	drivers/devfreq/governor_userspace.o
> > 
> > File size After adding 'const':
> >    text	   data	    bss	    dec	    hex	filename
> >    670	    144	      0	    814	    32e	drivers/devfreq/governor_userspace.o
> > 
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > ---
> >  drivers/devfreq/governor_userspace.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
[]
> 
> Looks good to me.
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Thank you. Applying to for-rc branch.


Cheers,
MyungJoo

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: Re: [PATCH] PM / devfreq: constify attribute_group structures. MyungJoo Ham <myungjoo.ham@samsung.com> - 2017-07-06 03:50 +0200

csiph-web