Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681966

Re: [PATCH] bcache: avoid a dangerous addressing in closure_queue

Show all headers | View raw

I had the same feeling, and was reluctant to do so. The reason for making this
change was that current code implicitly converts work_func_t to closure_fn, and
it also depends on the offset and size of a few struct not being changed. So the
patch was introduced essentially to solve that, and keep the impact small
meanwhile.

But as you pointed out, explicit casting is still bad too (was hoping it can be
considered less bad at this situation). I will think of a better idea
to handle this
issue unless people agree that the current behaviour is safe.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] bcache: avoid a dangerous addressing in closure_queue Liang Chen <liangchen.linux@gmail.com> - 2017-07-05 15:00 +0200
  Re: [PATCH] bcache: avoid a dangerous addressing in closure_queue Christoph Hellwig <hch@infradead.org> - 2017-07-05 21:40 +0200
    Re: [PATCH] bcache: avoid a dangerous addressing in closure_queue Liang Chen <liangchen.linux@gmail.com> - 2017-07-06 02:20 +0200
      Re: [PATCH] bcache: avoid a dangerous addressing in closure_queue Christoph Hellwig <hch@infradead.org> - 2017-07-06 05:40 +0200

csiph-web