Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681926

Re: OOPS from cciss_ioctl in 4.12+git

Show all headers | View raw

Hi Meelis,

can you try the patch below?

Also we're trying to move people away from the cciss driver, can you
check if the hpsa SCSI driver works for you as well?

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 02a611993bb4..678af946be30 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1944,6 +1944,13 @@ static void cciss_get_serial_no(ctlr_info_t *h, int logvol,
 	return;
 }
 
+static void cciss_initialize_rq(struct request *rq)
+{
+	struct scsi_request *sreq = blk_mq_rq_to_pdu(rq);
+
+	scsi_req_init(sreq);
+}
+
 /*
  * cciss_add_disk sets up the block device queue for a logical drive
  */
@@ -1956,6 +1963,7 @@ static int cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,
 
 	disk->queue->cmd_size = sizeof(struct scsi_request);
 	disk->queue->request_fn = do_cciss_request;
+	disk->queue->initialize_rq_fn = cciss_initialize_rq;
 	disk->queue->queue_lock = &h->lock;
 	queue_flag_set_unlocked(QUEUE_FLAG_SCSI_PASSTHROUGH, disk->queue);
 	if (blk_init_allocated_queue(disk->queue) < 0)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

OOPS from cciss_ioctl in 4.12+git Meelis Roos <mroos@linux.ee> - 2017-07-05 15:00 +0200
  Re: OOPS from cciss_ioctl in 4.12+git Christoph Hellwig <hch@infradead.org> - 2017-07-06 01:00 +0200
    Re: OOPS from cciss_ioctl in 4.12+git Meelis Roos <mroos@linux.ee> - 2017-07-06 12:00 +0200
      Re: device support in hpasa, was: Re: OOPS from cciss_ioctl in  4.12+git Jens Axboe <axboe@kernel.dk> - 2017-07-07 17:10 +0200
        Re: device support in hpasa, was: Re: OOPS from cciss_ioctl in  4.12+git Laurence Oberman <loberman@redhat.com> - 2017-07-07 17:50 +0200
          Re: device support in hpsa, was: Re: OOPS from cciss_ioctl in  4.12+git Christoph Hellwig <hch@infradead.org> - 2017-07-07 20:10 +0200
            Re: device support in hpsa, was: Re: OOPS from cciss_ioctl in  4.12+git Laurence Oberman <loberman@redhat.com> - 2017-07-07 20:30 +0200
            Re: device support in hpsa, was: Re: OOPS from cciss_ioctl in  4.12+git Meelis Roos <mroos@linux.ee> - 2017-07-10 16:10 +0200
        Re: device support in hpasa, was: Re: OOPS from cciss_ioctl in  4.12+git Hannes Reinecke <hare@suse.de> - 2017-07-07 18:10 +0200
      device support in hpasa, was: Re: OOPS from cciss_ioctl in 4.12+git Christoph Hellwig <hch@infradead.org> - 2017-07-07 17:10 +0200

csiph-web