Re: [PATCH 2/2] rtc: stm32: add STM32H7 RTC support

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] rtc: stm32: add STM32H7 RTC support
Date	2017-07-05 23:40 +0200
Message-ID	<u00bF-3nZ-41@gated-at.bofh.it> (permalink)
References	<tWyYi-I2-15@gated-at.bofh.it> <tWyYj-I2-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

This is mostly fine, even if I'm not too happy with the
s/ck_rtc/rtc_ck/.

On 26/06/2017 at 11:51:29 +0200, Amelie Delaunay wrote:
> -	rtc->ck_rtc = devm_clk_get(&pdev->dev, NULL);
> -	if (IS_ERR(rtc->ck_rtc)) {
> -		dev_err(&pdev->dev, "no ck_rtc clock");
> -		return PTR_ERR(rtc->ck_rtc);
> +	match = of_match_device(stm32_rtc_of_match, &pdev->dev);
> +	if (match && match->data)
> +		rtc->data = (struct stm32_rtc_data *)match->data;
> +	else
> +		return -EINVAL;

This will never happen, you can remove that test.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] rtc: stm32: add STM32H7 RTC support Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-07-05 23:40 +0200
  Re: [PATCH 2/2] rtc: stm32: add STM32H7 RTC support Amelie DELAUNAY <amelie.delaunay@st.com> - 2017-07-06 09:40 +0200

csiph-web