Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1681850

[RFC v5 13/38] x86: disallow pkey creation with PKEY_DISABLE_EXECUTE

From Ram Pai <linuxram@us.ibm.com>
Newsgroups linux.kernel
Subject [RFC v5 13/38] x86: disallow pkey creation with PKEY_DISABLE_EXECUTE
Date 2017-07-05 23:40 +0200
Message-ID <u00bE-3nZ-9@gated-at.bofh.it> (permalink)
References <u001X-3kP-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


x86 does not support disabling execute permissions on a pkey.

Signed-off-by: Ram Pai <linuxram@us.ibm.com>
---
 arch/x86/kernel/fpu/xstate.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/fpu/xstate.c b/arch/x86/kernel/fpu/xstate.c
index c24ac1e..d582631 100644
--- a/arch/x86/kernel/fpu/xstate.c
+++ b/arch/x86/kernel/fpu/xstate.c
@@ -900,6 +900,9 @@ int arch_set_user_pkey_access(struct task_struct *tsk, int pkey,
 	if (!boot_cpu_has(X86_FEATURE_OSPKE))
 		return -EINVAL;
 
+	if (init_val & PKEY_DISABLE_EXECUTE)
+		return -EINVAL;
+
 	/* Set the bits we need in PKRU:  */
 	if (init_val & PKEY_DISABLE_ACCESS)
 		new_pkru_bits |= PKRU_AD_BIT;
-- 
1.7.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[RFC v5 13/38] x86: disallow pkey creation with PKEY_DISABLE_EXECUTE Ram Pai <linuxram@us.ibm.com> - 2017-07-05 23:40 +0200
  Re: [RFC v5 13/38] x86: disallow pkey creation with  PKEY_DISABLE_EXECUTE Dave Hansen <dave.hansen@intel.com> - 2017-07-11 20:20 +0200

csiph-web