Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1681832
| From | Stefano Stabellini <sstabellini@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6 15/18] xen/pvcalls: implement the ioworker functions |
| Date | 2017-07-05 23:30 +0200 |
| Message-ID | <u001Z-3kP-35@gated-at.bofh.it> (permalink) |
| References | <tZgLv-75o-7@gated-at.bofh.it> <tZgLv-75o-9@gated-at.bofh.it> <tZgVd-7a5-43@gated-at.bofh.it> <tZqKS-5ky-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 4 Jul 2017, Juergen Gross wrote:
> On 03/07/17 23:08, Stefano Stabellini wrote:
> > We have one ioworker per socket. Each ioworker goes through the list of
> > outstanding read/write requests. Once all requests have been dealt with,
> > it returns.
> >
> > We use one atomic counter per socket for "read" operations and one
> > for "write" operations to keep track of the reads/writes to do.
> >
> > We also use one atomic counter ("io") per ioworker to keep track of how
> > many outstanding requests we have in total assigned to the ioworker. The
> > ioworker finishes when there are none.
> >
> > Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
> > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > CC: boris.ostrovsky@oracle.com
> > CC: jgross@suse.com
> > ---
> > drivers/xen/pvcalls-back.c | 27 +++++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> >
> > diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> > index 71a42fc..d59c2e4 100644
> > --- a/drivers/xen/pvcalls-back.c
> > +++ b/drivers/xen/pvcalls-back.c
> > @@ -96,8 +96,35 @@ static int pvcalls_back_release_active(struct xenbus_device *dev,
> > struct pvcalls_fedata *fedata,
> > struct sock_mapping *map);
> >
> > +static void pvcalls_conn_back_read(void *opaque)
> > +{
> > +}
> > +
> > +static int pvcalls_conn_back_write(struct sock_mapping *map)
> > +{
> > + return 0;
> > +}
>
> Any reason for letting this function return int? I haven't spotted any
> use of the return value in this or any later patch.
No reason. I'll change it to void.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v6 00/18] introduce the Xen PV Calls backend Stefano Stabellini <stefano@aporeto.com> - 2017-07-03 23:10 +0200
[PATCH v6 02/18] xen/pvcalls: introduce the pvcalls xenbus backend Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:10 +0200
[PATCH v6 16/18] xen/pvcalls: implement read Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:10 +0200
Re: [PATCH v6 16/18] xen/pvcalls: implement read Juergen Gross <jgross@suse.com> - 2017-07-04 09:40 +0200
[PATCH v6 08/18] xen/pvcalls: implement connect command Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:10 +0200
Re: [PATCH v6 08/18] xen/pvcalls: implement connect command Juergen Gross <jgross@suse.com> - 2017-07-04 09:20 +0200
Re: [PATCH v6 08/18] xen/pvcalls: implement connect command Stefano Stabellini <sstabellini@kernel.org> - 2017-07-05 23:20 +0200
[PATCH v6 07/18] xen/pvcalls: implement socket command Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:10 +0200
[PATCH v6 05/18] xen/pvcalls: connect to a frontend Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:10 +0200
Re: [PATCH v6 05/18] xen/pvcalls: connect to a frontend Juergen Gross <jgross@suse.com> - 2017-07-04 09:00 +0200
Re: [PATCH v6 05/18] xen/pvcalls: connect to a frontend Stefano Stabellini <sstabellini@kernel.org> - 2017-07-05 22:40 +0200
[PATCH v6 13/18] xen/pvcalls: implement release command Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:10 +0200
Re: [PATCH v6 13/18] xen/pvcalls: implement release command Juergen Gross <jgross@suse.com> - 2017-07-04 09:40 +0200
[PATCH v6 06/18] xen/pvcalls: handle commands from the frontend Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:20 +0200
Re: [PATCH v6 06/18] xen/pvcalls: handle commands from the frontend Juergen Gross <jgross@suse.com> - 2017-07-04 09:00 +0200
Re: [PATCH v6 06/18] xen/pvcalls: handle commands from the frontend Stefano Stabellini <sstabellini@kernel.org> - 2017-07-05 22:50 +0200
[PATCH v6 01/18] xen: introduce the pvcalls interface header Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:20 +0200
[PATCH v6 11/18] xen/pvcalls: implement accept command Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:20 +0200
Re: [PATCH v6 11/18] xen/pvcalls: implement accept command Juergen Gross <jgross@suse.com> - 2017-07-04 09:30 +0200
[PATCH v6 09/18] xen/pvcalls: implement bind command Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:20 +0200
Re: [PATCH v6 09/18] xen/pvcalls: implement bind command Juergen Gross <jgross@suse.com> - 2017-07-04 09:30 +0200
Re: [PATCH v6 09/18] xen/pvcalls: implement bind command Stefano Stabellini <sstabellini@kernel.org> - 2017-07-05 23:20 +0200
[PATCH v6 14/18] xen/pvcalls: disconnect and module_exit Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:20 +0200
Re: [PATCH v6 14/18] xen/pvcalls: disconnect and module_exit Juergen Gross <jgross@suse.com> - 2017-07-04 09:40 +0200
Re: [PATCH v6 14/18] xen/pvcalls: disconnect and module_exit Stefano Stabellini <sstabellini@kernel.org> - 2017-07-05 23:30 +0200
[PATCH v6 03/18] xen/pvcalls: initialize the module and register the xenbus backend Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:20 +0200
[PATCH v6 12/18] xen/pvcalls: implement poll command Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:20 +0200
Re: [PATCH v6 12/18] xen/pvcalls: implement poll command Juergen Gross <jgross@suse.com> - 2017-07-04 09:30 +0200
[PATCH v6 10/18] xen/pvcalls: implement listen command Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:20 +0200
[PATCH v6 04/18] xen/pvcalls: xenbus state handling Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:20 +0200
Re: [PATCH v6 04/18] xen/pvcalls: xenbus state handling Juergen Gross <jgross@suse.com> - 2017-07-04 10:10 +0200
Re: [PATCH v6 04/18] xen/pvcalls: xenbus state handling Stefano Stabellini <sstabellini@kernel.org> - 2017-07-05 22:30 +0200
[PATCH v6 15/18] xen/pvcalls: implement the ioworker functions Stefano Stabellini <sstabellini@kernel.org> - 2017-07-03 23:20 +0200
Re: [PATCH v6 15/18] xen/pvcalls: implement the ioworker functions Juergen Gross <jgross@suse.com> - 2017-07-04 09:50 +0200
Re: [PATCH v6 15/18] xen/pvcalls: implement the ioworker functions Stefano Stabellini <sstabellini@kernel.org> - 2017-07-05 23:30 +0200
csiph-web