Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1629081

[PATCH] staging: rtl8192u: Fix sparse warning

From Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] staging: rtl8192u: Fix sparse warning
Date 2017-04-23 23:00 +0200
Message-ID <tzwLU-58b-17@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Fix the following sparse warning:
rtl8192u/ieee80211/ieee80211_rx.c:1489:45: warning: incorrect type in assignment (different base types)
rtl8192u/ieee80211/ieee80211_rx.c:1489:45:    expected restricted __le16 <noident>
rtl8192u/ieee80211/ieee80211_rx.c:1489:45:    got unsigned short [unsigned] [usertype] <noident>

Since ac_params->tx_op_limit is already an __le16, we shouldn't convert it into cpu type.

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---

 Sorry, I don't have the hardware to test, so please review and tell me if I'm wrong in this one!

 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index 5241c50..3a6a533 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -1486,7 +1486,7 @@ static int ieee80211_qos_convert_ac_to_parameters(struct
 
 		qos_param->flag[aci] =
 		    (ac_params->aci_aifsn & 0x10) ? 0x01 : 0x00;
-		qos_param->tx_op_limit[aci] = le16_to_cpu(ac_params->tx_op_limit);
+		qos_param->tx_op_limit[aci] = ac_params->tx_op_limit;
 	}
 	return 0;
 }
-- 
2.9.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] staging: rtl8192u: Fix sparse warning Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2017-04-23 23:00 +0200

csiph-web