Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()
Date	2017-04-23 13:20 +0200
Message-ID	<tznIB-7LL-3@gated-at.bofh.it> (permalink)
References	<tzaLn-81z-1@gated-at.bofh.it> <tzaLn-81z-5@gated-at.bofh.it> <tzmCR-794-9@gated-at.bofh.it> <tznfA-7mZ-13@gated-at.bofh.it> <tznfA-7mZ-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply
> For example. Also I just noticed some previous comment by Krzysztof that
> pointed that out already.
> 
> My suggestion: One sentence describing that the current situation is.

Why do you find the sentence for the multiplication information inappropriate
(or incomplete) at the moment?


> Another sentence explaining why this is bad/undesirable.

Which details do you miss here?


> In this case, the output of the checkpatch script would come in handy.

Its implementation of the check “ALLOC_WITH_MULTIPLY” considers only an other
search pattern so far.

* Do you find it worthwhile to add a prefix like “devm_” to the used
  regular expression?

* Would like to improve any related scripts for the semantic patch language
  (Coccinelle software) a bit more?


> With this, you avoid cramming every information into one long and
> complicated sentence.

Thanks for your feedback about other wording preferences.

Regards,
Markus

Thread

[PATCH 0/2] dmaengine: s3c24xx: Fine-tuning for s3c24xx_dma_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 23:30 +0200
  [PATCH 1/2] dmaengine: s3c24xx: Use devm_kcalloc() in  s3c24xx_dma_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 23:30 +0200
    Re: [PATCH 1/2] dmaengine: s3c24xx: Use devm_kcalloc() in  s3c24xx_dma_probe() Tobias Jakobi <tjakobi@math.uni-bielefeld.de> - 2017-04-23 12:10 +0200
      Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe() Tobias Jakobi <tjakobi@math.uni-bielefeld.de> - 2017-04-23 12:50 +0200
        Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-23 13:20 +0200
          Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe() Tobias Jakobi <tjakobi@math.uni-bielefeld.de> - 2017-04-23 14:20 +0200
            Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-23 14:40 +0200
      Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-23 12:50 +0200
  [PATCH 2/2] dmaengine: s3c24xx: Fix a typo in a comment line SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 23:30 +0200

csiph-web