Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1628941
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/4] scsi: pmcraid: fix endianess sparse annotations |
| Date | 2017-04-23 10:50 +0200 |
| Message-ID | <tzlns-68k-9@gated-at.bofh.it> (permalink) |
| References | <tyox3-3vH-3@gated-at.bofh.it> <tyox4-3vH-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> mb(); > - iowrite32(le32_to_cpu(cmd->ioa_cb->ioarcb.ioarcb_bus_addr), > - pinstance->ioarrin); > + iowrite32(le64_to_cpu(cmd->ioa_cb->ioarcb.ioarcb_bus_addr), pinstance->ioarrin); It really seems like some of these fields should be swapped once and store in an in-memory structure. But for now this patch looks fine to me: Reviewed-by: Christoph Hellwig <hch@lst.de>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 3/4] scsi: pmcraid: fix endianess sparse annotations Arnd Bergmann <arnd@arndb.de> - 2017-04-20 20:00 +0200 Re: [PATCH 3/4] scsi: pmcraid: fix endianess sparse annotations Christoph Hellwig <hch@infradead.org> - 2017-04-23 10:50 +0200
csiph-web