Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1630164

Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

From Michel Dänzer <michel@daenzer.net>
Newsgroups linux.kernel
Subject Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format
Date 2017-04-25 05:20 +0200
Message-ID <tzZbb-7xO-13@gated-at.bofh.it> (permalink)
References <tzFFv-3rT-3@gated-at.bofh.it> <tzFFv-3rT-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 24/04/17 03:25 PM, Gerd Hoffmann wrote:
> Return correct fourcc codes on bigendian.  Drivers must be adapted to
> this change.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Just to reiterate, this won't work for the radeon driver, which programs
the GPU to use (effectively, per the current definition that these are
little endian GPU formats) DRM_FORMAT_XRGB8888 with pre-R600 and
DRM_FORMAT_BGRX8888 with >= R600.


> +#ifdef __BIG_ENDIAN
> +	switch (bpp) {
> +	case 8:
> +		fmt = DRM_FORMAT_C8;
> +		break;
> +	case 24:
> +		fmt = DRM_FORMAT_BGR888;
> +		break;

BTW, endianness as a concept cannot apply to 8 or 24 bpp formats.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format Gerd Hoffmann <kraxel@redhat.com> - 2017-04-24 08:30 +0200
  Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Michel Dänzer <michel@daenzer.net> - 2017-04-25 05:20 +0200
    Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-04-25 12:00 +0200
      Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Michel Dänzer <michel@daenzer.net> - 2017-04-26 04:10 +0200
        Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-04-26 16:40 +0200
    Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Gerd Hoffmann <kraxel@redhat.com> - 2017-04-26 08:00 +0200
      Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Michel Dänzer <michel@daenzer.net> - 2017-04-26 11:40 +0200
        Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Gerd Hoffmann <kraxel@redhat.com> - 2017-04-26 14:20 +0200
          Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Michel Dänzer <michel@daenzer.net> - 2017-04-27 03:00 +0200
            Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Gerd Hoffmann <kraxel@redhat.com> - 2017-04-27 08:50 +0200
              Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Michel Dänzer <michel@daenzer.net> - 2017-04-27 09:10 +0200
                Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Gerd Hoffmann <kraxel@redhat.com> - 2017-04-28 12:10 +0200
      Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Eric Engestrom <eric.engestrom@imgtec.com> - 2017-04-26 15:30 +0200
        Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to  drm_mode_legacy_fb_format Gerd Hoffmann <kraxel@redhat.com> - 2017-04-26 16:00 +0200

csiph-web