Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1630166

[PATCH -next] firmware: google memconsole: Fix return value check in platform_memconsole_init()

Show all headers | View raw

From: Wei Yongjun <weiyongjun1@huawei.com>

In case of error, the function platform_device_register_simple() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().

Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/firmware/google/memconsole-coreboot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/google/memconsole-coreboot.c b/drivers/firmware/google/memconsole-coreboot.c
index 2121014..0271111 100644
--- a/drivers/firmware/google/memconsole-coreboot.c
+++ b/drivers/firmware/google/memconsole-coreboot.c
@@ -95,8 +95,8 @@ static int __init platform_memconsole_init(void)
 	struct platform_device *pdev;
 
 	pdev = platform_device_register_simple("memconsole", -1, NULL, 0);
-	if (pdev == NULL)
-		return -ENODEV;
+	if (IS_ERR(pdev))
+		return PTR_ERR(pdev);
 
 	platform_driver_register(&memconsole_driver);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH -next] firmware: google memconsole: Fix return value check in platform_memconsole_init() Wei Yongjun <weiyj.lk@gmail.com> - 2017-04-25 05:20 +0200

csiph-web