Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1630149

Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock

From Michael Schmitz <schmitzmic@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock
Date 2017-04-25 04:20 +0200
Message-ID <tzYf7-6TM-1@gated-at.bofh.it> (permalink)
References <trHOa-5JE-3@gated-at.bofh.it> <tzUOd-4s5-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Martin,

looks good to me, so:

Reviewed-By: Michael Schmitz <schmitzmic@gmail.com>


Am 25.04.2017 um 10:29 schrieb Martin K. Petersen:
> 
> Finn,
> 
>> Commit da244654c66e ("[SCSI] mac_esp: fix for quadras with two esp chips")
>> added mac_scsi_esp_intr() to handle the IRQ lines from a pair of on-board
>> ESP chips (a normal shared IRQ did not work).
>>
>> Proper mutual exclusion was missing from that patch. This patch fixes
>> race conditions between comparison and assignment of esp_chips[]
>> pointers.
> 
> Ondrej/Michael: Mind reviewing this change?
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-04-25 00:40 +0200
  Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock Michael Schmitz <schmitzmic@gmail.com> - 2017-04-25 04:20 +0200
    Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-04-25 19:00 +0200

csiph-web