[PATCH] iio: core: Fix suspicious sizeof usage

From	Orson Zhai <orson.zhai@spreadtrum.com>
Newsgroups	linux.kernel
Subject	[PATCH] iio: core: Fix suspicious sizeof usage
Date	2017-04-25 03:50 +0200
Message-ID	<tzXM5-6p1-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Pointer size is variours in different system, say 32bit for 4 and 64bit
for 8. The 'sizeof(infomask)' may lead to wrong bit numbers.

Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com>
---
 drivers/iio/industrialio-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 3ff91e0..795f53c 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -1089,7 +1089,7 @@ static int iio_device_add_info_mask_type(struct iio_dev *indio_dev,
 {
 	int i, ret, attrcount = 0;
 
-	for_each_set_bit(i, infomask, sizeof(infomask)*8) {
+	for_each_set_bit(i, infomask, sizeof(*infomask)*8) {
 		if (i >= ARRAY_SIZE(iio_chan_info_postfix))
 			return -EINVAL;
 		ret = __iio_add_chan_devattr(iio_chan_info_postfix[i],
@@ -1118,7 +1118,7 @@ static int iio_device_add_info_mask_type_avail(struct iio_dev *indio_dev,
 	int i, ret, attrcount = 0;
 	char *avail_postfix;
 
-	for_each_set_bit(i, infomask, sizeof(infomask) * 8) {
+	for_each_set_bit(i, infomask, sizeof(*infomask) * 8) {
 		avail_postfix = kasprintf(GFP_KERNEL,
 					  "%s_available",
 					  iio_chan_info_postfix[i]);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: core: Fix suspicious sizeof usage Orson Zhai <orson.zhai@spreadtrum.com> - 2017-04-25 03:50 +0200
  Re: [PATCH] iio: core: Fix suspicious sizeof usage Jonathan Cameron <jic23@kernel.org> - 2017-04-27 07:40 +0200
    Re: [PATCH] iio: core: Fix suspicious sizeof usage Orson Zhai <orson.zhai@spreadtrum.com> - 2017-04-27 09:40 +0200

csiph-web