Re: [PATCH v3 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/3] mtd: nand: Cleanup/rework the atmel_nand driver
Date	2017-04-25 03:10 +0200
Message-ID	<tzX9n-6aR-7@gated-at.bofh.it> (permalink)
References	<tlyDU-3Np-17@gated-at.bofh.it> <tlyDV-3Np-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 16, 2017 at 09:02:40AM +0100, Boris Brezillon wrote:

> diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> new file mode 100644
> index 000000000000..f71b9e5d7d9d
> --- /dev/null
> +++ b/drivers/mtd/nand/atmel/nand-controller.c
> @@ -0,0 +1,2198 @@
[...]

> +static int
> +atmel_hsmc_nand_controller_legacy_init(struct atmel_hsmc_nand_controller *nc)
> +{
> +	struct regmap_config regmap_conf = {
> +		.reg_bits = 32,
> +		.val_bits = 32,
> +		.reg_stride = 4,
> +		.val_bits = 32,

You assigned val_bits twice. Is that just a harmless mistake, or did you
mean to set something else?

(sparse and other tools complain about this)

> +	};


Brian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Brian Norris <computersforpeace@gmail.com> - 2017-04-25 03:10 +0200
  Re: [PATCH v3 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-04-25 09:00 +0200

csiph-web