Re: [PATCH] scsi: mvumi: remove code handling zero scsi_sg_count(scmd) case

From	"Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: mvumi: remove code handling zero scsi_sg_count(scmd) case
Date	2017-04-25 00:20 +0200
Message-ID	<tzUuS-4jY-3@gated-at.bofh.it> (permalink)
References	<tzyNH-6NS-7@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

Alexey,

> As Christoph Hellwig noted, SCSI commands that transfer data
> always have a SG entry. The patch removes dead code in
> mvumi_make_sgl(),  mvumi_complete_cmd() and mvumi_timed_out()
> that handle zero scsi_sg_count(scmd) case.
>
> Also the patch adds pci_unmap_sg() on failure path in mvumi_make_sgl().

Applied to 4.12/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: mvumi: add check for dma mapping errors Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-04-22 01:20 +0200
  Re: [PATCH] scsi: mvumi: add check for dma mapping errors Christoph Hellwig <hch@infradead.org> - 2017-04-23 10:50 +0200
    [PATCH] scsi: mvumi: remove code handling zero scsi_sg_count(scmd) case Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-04-24 01:10 +0200
      Re: [PATCH] scsi: mvumi: remove code handling zero  scsi_sg_count(scmd) case Christoph Hellwig <hch@infradead.org> - 2017-04-24 08:40 +0200
      Re: [PATCH] scsi: mvumi: remove code handling zero scsi_sg_count(scmd) case "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-04-25 00:20 +0200

csiph-web