Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1630071

Re: [PATCH 2/4] scsi: pmcraid: fix lock imbalance in pmcraid_reset_reload()

From "Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/4] scsi: pmcraid: fix lock imbalance in pmcraid_reset_reload()
Date 2017-04-25 00:10 +0200
Message-ID <tzUlb-4gQ-11@gated-at.bofh.it> (permalink)
References <tyox3-3vH-3@gated-at.bofh.it> <tyox4-3vH-15@gated-at.bofh.it> <tzldL-652-1@gated-at.bofh.it>
Organization Oracle Corporation

Show all headers | View raw


Christoph,

> sparse found a bug that has always been present since the driver was
> merged:
>
> drivers/scsi/pmcraid.c:2353:12: warning: context imbalance in 'pmcraid_reset_reload' - different lock contexts for basic block
>
> Fix this by using a common unlock goto label, and also reduce the
> indentation level in the function.

Applied to 4.12/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 2/4] scsi: pmcraid: fix lock imbalance in pmcraid_reset_reload() Arnd Bergmann <arnd@arndb.de> - 2017-04-20 20:00 +0200
  Re: [PATCH 2/4] scsi: pmcraid: fix lock imbalance in  pmcraid_reset_reload() Christoph Hellwig <hch@infradead.org> - 2017-04-23 10:40 +0200
    Re: [PATCH 2/4] scsi: pmcraid: fix lock imbalance in pmcraid_reset_reload() "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-04-25 00:10 +0200

csiph-web