Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] platform/x86/intel-vbtn: add volume up and down
Date	Mon, 24 Apr 2017 23:40:01 +0200
Message-ID	<tzTS9-3S5-3@gated-at.bofh.it> (permalink)
References	<tzTIt-3OV-11@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kOWJEvW/o57ioMtfDW7tqMgTjUOQJ5g05cufzSjflrc=; b=ISyJkwzLlQg0VKJwu9OTMf38FgMRAKCauv+TkV6BfyWIwoyh488xeaVeMCF/IVEimt KGmn4exnd1tQ9rWro3KKz3OpTf8q1oLHLS+YLSowNwHEGZ5YFDDv6XPA3+7sNUc6GY/l pC0DGY1rMCCbPnpggLZmFlHQBXveMPsDRd8ywlKXeVnEfgsRVPmCXCdFjWePjfkakNJE nZSiovtciS+pWNGMhbdXWkunJNblLjTMZtbb4us0N2azktArynkatxyCZeZO603q0YX5 bpIrFP0ZgnwUbT3YOGt8yfAnr3rlbgfdVrjth04G7N6ZonTuwq/0WhInTg8xieMieIQA PlFQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kOWJEvW/o57ioMtfDW7tqMgTjUOQJ5g05cufzSjflrc=; b=qjLs7X5Dx2mJsKU8WvL6VL8Xj9H9XWwp1hsWvvBsU+JEdOBfoX7iizGeo06RGcLQFO r4NbAOu+lPbr5KSCSU1jM/BANELCsHrjulIHbaP94jkRhp3Jic2Ngftafau5BXd1f66B Dd5SqNE57iPQp33ShB0m1reTiry4V/ITw8tEU1dO+P094L6XmiCl7o2ygJQaZUs+LbiM UeUNoYhkpFIcvyc09B/1yJmbXLC9i+21LM/j9vgMe7fdicNG9Bn6H3dKk4Pf2e2GmRY5 icn3Wod0wD+V/ppHS209JWiHZiGOWNq9vAIXZFWMZLaVil86tds4ORMfyA0iX/zZ7Dw0 K00Q==
X-Gm-Message-State	AN3rC/6oVApLrQjGGzuKiDqkTz7lu755eHn9FCthJOp3YwPvdbrhxirS GZbj0UTTRq/gs/edIo9DS2i2dAAE+g==
X-Received	by 10.200.43.225 with SMTP id n30mr29777995qtn.12.1493069874024; Mon, 24 Apr 2017 14:37:54 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	AceLan Kao <acelan.kao@canonical.com>, "dvhart@infradead.org" <dvhart@infradead.org>, Platform Driver <platform-driver-x86@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Maarten Maathuis <madman2003@shikahr.net>
X-Original-Date	Tue, 25 Apr 2017 00:37:53 +0300
X-Original-Message-ID	<CAHp75VeWJt0uVbKg_8_GBP3-JUQ3H0BLzBjFeyqcRfekK9VjNA@mail.gmail.com>
X-Original-References	<20170424212908.10055-1-madman2003@shikahr.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1630044

Show key headers only | View raw

On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis <madman2003@gmail.com> wrote:
> Tested on HP Elite X2 1012 G1.
> Matches event report of Lenovo Helix 2
> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).
>

Much better!

> V2: Fix indent and add sign-off

Usually this line goes after --- (body delimiter).
No need to resend this time. I would wait a bit for actual
author/driver maintainer to comment. Otherwise patch looks good enough
to me.

>
> Signed-off-by: Maarten Maathuis <madman2003@shikahr.net>
> ---
>  drivers/platform/x86/intel-vbtn.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 554e82ebe83c..1616cb9c4ae5 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -37,6 +37,10 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
>  static const struct key_entry intel_vbtn_keymap[] = {
>         { KE_IGNORE, 0xC0, { KEY_POWER } },     /* power key press */
>         { KE_KEY, 0xC1, { KEY_POWER } },        /* power key release */
> +       { KE_KEY, 0xC4, { KEY_VOLUMEUP} },      /* volume-up key press */
> +       { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },  /* volume-up key release */
> +       { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },   /* volume-down key press */
> +       { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },        /* volume-down key release */
>         { KE_END },
>  };
>
> --
> 2.12.2
>



-- 
With Best Regards,
Andy Shevchenko

Thread

[PATCH] platform/x86/intel-vbtn: add volume up and down Maarten Maathuis <madman2003@gmail.com> - 2017-04-24 23:30 +0200
  Re: [PATCH] platform/x86/intel-vbtn: add volume up and down Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-24 23:40 +0200
    Re: [PATCH] platform/x86/intel-vbtn: add volume up and down Maarten Maathuis <madman2003@gmail.com> - 2017-04-24 23:50 +0200
      Re: [PATCH] platform/x86/intel-vbtn: add volume up and down AceLan Kao <acelan.kao@canonical.com> - 2017-04-25 04:50 +0200
        Re: [PATCH] platform/x86/intel-vbtn: add volume up and down Maarten Maathuis <madman2003@gmail.com> - 2017-04-25 07:10 +0200
          Re: [PATCH] platform/x86/intel-vbtn: add volume up and down AceLan Kao <acelan.kao@canonical.com> - 2017-04-25 08:20 +0200

csiph-web