Re: [PATCH 22/22] perf tools: Fix the code to strip command name

From	David Ahern <dsahern@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 22/22] perf tools: Fix the code to strip command name
Date	2017-04-24 22:10 +0200
Message-ID	<tzSt4-33H-27@gated-at.bofh.it> (permalink)
References	<tzSjn-2Lp-3@gated-at.bofh.it> <tzSjp-2Lp-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 4/24/17 1:54 PM, Arnaldo Carvalho de Melo wrote:
> From: Jiri Olsa <jolsa@kernel.org>
> 
> Recent commit broke command name strip in perf_event__get_comm_ids
> function. It replaced left to right search for '\n' with rtrim, which
> actually does right to left search. It occasionally caught earlier '\n'
> and kept trash in the command name.
> 

interesting. When I reviewed that patch it didn't cross my mind that a
comm Name could have a newline in it. seems very odd to do so.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 22/22] perf tools: Fix the code to strip command name Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-24 22:00 +0200
  Re: [PATCH 22/22] perf tools: Fix the code to strip command name David Ahern <dsahern@gmail.com> - 2017-04-24 22:10 +0200

csiph-web