Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629988

Re: [PATCH 1/2] [media] vb2: Fix an off by one error in 'vb2_plane_vaddr'

Show all headers | View raw

Hi Christophe,

On Mon, Apr 24, 2017 at 10:00:24PM +0200, Christophe JAILLET wrote:
> Le 24/04/2017 à 16:16, Sakari Ailus a écrit :
> >On Sun, Apr 23, 2017 at 11:32:57PM +0200, Christophe JAILLET wrote:
> >>We should ensure that 'plane_no' is '< vb->num_planes' as done in
> >>'vb2_plane_cookie' just a few lines below.
> >>
> >>Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> >>---
> >>  drivers/media/v4l2-core/videobuf2-core.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
> >>index 94afbbf92807..c0175ea7e7ad 100644
> >>--- a/drivers/media/v4l2-core/videobuf2-core.c
> >>+++ b/drivers/media/v4l2-core/videobuf2-core.c
> >>@@ -868,7 +868,7 @@ EXPORT_SYMBOL_GPL(vb2_core_create_bufs);
> >>  void *vb2_plane_vaddr(struct vb2_buffer *vb, unsigned int plane_no)
> >>  {
> >>-	if (plane_no > vb->num_planes || !vb->planes[plane_no].mem_priv)
> >>+	if (plane_no >= vb->num_planes || !vb->planes[plane_no].mem_priv)
> >>  		return NULL;
> >>  	return call_ptr_memop(vb, vaddr, vb->planes[plane_no].mem_priv);
> >Oh my. How could this happen?
> >
> >This should go to stable as well.
> Should I resubmit with "Cc: stable@vger.kernel.org" or will you add it
> yourself?

Please resend. And preferrably figure out which version is the first one
requiring the fix.

Mauro can then pick it up, and it ends up to stable through his tree. I.e.
Cc: stable ... tag is enough, no need to send an actual  e-mail there.

Thanks!

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] [media] vb2: Fix an off by one error in 'vb2_plane_vaddr' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-04-23 23:50 +0200
  Re: [PATCH 1/2] [media] vb2: Fix an off by one error in  'vb2_plane_vaddr' Sakari Ailus <sakari.ailus@iki.fi> - 2017-04-24 16:20 +0200
    Re: [PATCH 1/2] [media] vb2: Fix an off by one error in  'vb2_plane_vaddr' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-04-24 22:10 +0200
      Re: [PATCH 1/2] [media] vb2: Fix an off by one error in  'vb2_plane_vaddr' Sakari Ailus <sakari.ailus@iki.fi> - 2017-04-24 22:30 +0200
        Re: [PATCH 1/2] [media] vb2: Fix an off by one error in  'vb2_plane_vaddr' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-04-25 08:20 +0200
          Re: [PATCH 1/2] [media] vb2: Fix an off by one error in  'vb2_plane_vaddr' Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-25 15:00 +0200

csiph-web