Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629893

Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks

From Daniel Bristot de Oliveira <bristot@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks
Date 2017-04-24 21:00 +0200
Message-ID <tzRnk-2cE-13@gated-at.bofh.it> (permalink)
References <tzNWq-ba-7@gated-at.bofh.it> <tzPET-1jt-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 04/24/2017 07:00 PM, Steven Rostedt wrote:
>> +static void
>> +update_dl_revised_wakeup(struct sched_dl_entity *dl_se, struct rq *rq)
>> +{
>> +	u64 density = div64_u64(dl_se->dl_runtime << 20, dl_se->dl_deadline);
> Hmm, dl_runtime and dl_deadline don't get updated that often. Can't we
> simply keep a static dl_se->dl_density, and update it when dl_runtime
> or dl_deadline get updated? That would get rid of the divide in the
> middle of a wake up call.

Yeah, I agree! Juri also pointed in the same direction, I will add it in
the possible next version ;-).

Thanks for the feedback!

-- Daniel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC] sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-04-24 17:20 +0200
  Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for  suspending constrained dl tasks Steven Rostedt <rostedt@goodmis.org> - 2017-04-24 19:10 +0200
    Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for  suspending constrained dl tasks Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-04-24 21:00 +0200
  Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for  suspending constrained dl tasks Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-04-24 22:50 +0200
  Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for  suspending constrained dl tasks Peter Zijlstra <peterz@infradead.org> - 2017-05-04 16:20 +0200
    Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for  suspending constrained dl tasks Peter Zijlstra <peterz@infradead.org> - 2017-05-04 16:30 +0200
      Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for  suspending constrained dl tasks Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-05-11 19:10 +0200
    Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for  suspending constrained dl tasks Peter Zijlstra <peterz@infradead.org> - 2017-05-04 17:30 +0200
      Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for  suspending constrained dl tasks Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-05-11 19:10 +0200
    Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for  suspending constrained dl tasks Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-05-11 19:10 +0200

csiph-web