Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1629884

Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu irq request

From Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu irq request
Date 2017-04-24 20:40 +0200
Message-ID <tzR3X-26a-5@gated-at.bofh.it> (permalink)
References <tzMQF-80I-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Apr 24, 2017 at 04:01:31PM +0200, Daniel Lezcano wrote:
> In the next changes, we track when the interrupts occur in order to
> statistically compute when is supposed to happen the next interrupt.
> 
> In all the interruptions, it does not make sense to store the timer interrupt
> occurences and try to predict the next interrupt as when know the expiration
> time.
> 
> The request_irq() has a irq flags parameter and the timer drivers use it to
> pass the IRQF_TIMER flag, letting us know the interrupt is coming from a timer.
> Based on this flag, we can discard these interrupts when tracking them.
> 
> But, the API request_percpu_irq does not allow to pass a flag, hence specifying
> if the interrupt type is a timer.
> 
> Add a function request_percpu_irq_flags() where we can specify the flags. The
> request_percpu_irq() function is changed to be a wrapper to
> request_percpu_irq_flags() passing a zero flag parameter.
> 
> Change the timers using request_percpu_irq() to use request_percpu_irq_flags()
> instead with the IRQF_TIMER flag set.
> 
> For now, in order to prevent a misusage of this parameter, only the IRQF_TIMER
> flag (or zero) is a valid parameter to be passed to the
> request_percpu_irq_flags() function.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
> Cc: Christoffer Dall <christoffer.dall@linaro.org>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> 
> ---
> Changelog:
> 
>    V9:
> 	- Clarified the patch description
> 	- Fixed EXPORT_SYMBOL_GPL(request_percpu_irq_flags)
> ---
>  arch/arm/kernel/smp_twd.c                |  3 ++-
>  drivers/clocksource/arc_timer.c          |  4 ++--
>  drivers/clocksource/arm_arch_timer.c     | 20 ++++++++++++--------
>  drivers/clocksource/arm_global_timer.c   |  4 ++--
>  drivers/clocksource/exynos_mct.c         |  7 ++++---
>  drivers/clocksource/qcom-timer.c         |  4 ++--
>  drivers/clocksource/time-armada-370-xp.c |  9 +++++----
>  drivers/clocksource/timer-nps.c          |  6 +++---
>  include/linux/interrupt.h                | 11 ++++++++++-
>  kernel/irq/manage.c                      | 15 ++++++++++-----
>  virt/kvm/arm/arch_timer.c                |  5 +++--
>  11 files changed, 55 insertions(+), 33 deletions(-)
>

For exynos-mct:
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu irq request Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-24 16:10 +0200
  [PATCH V9 3/3] irq: Compute the periodic interval for interrupts Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-24 16:10 +0200
  [PATCH V9 2/3] irq: Track the interrupt timings Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-24 16:10 +0200
  Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with  percpu irq request Krzysztof Kozlowski <krzk@kernel.org> - 2017-04-24 20:40 +0200
  Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu  irq request Marc Zyngier <marc.zyngier@arm.com> - 2017-04-24 20:50 +0200
    Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with  percpu irq request Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-24 21:00 +0200
      Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu  irq request Marc Zyngier <marc.zyngier@arm.com> - 2017-04-24 21:20 +0200
        Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with  percpu irq request Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-24 22:10 +0200
          Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu  irq request Marc Zyngier <marc.zyngier@arm.com> - 2017-04-25 09:50 +0200
            Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with  percpu irq request Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-25 10:40 +0200
              Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu  irq request Marc Zyngier <marc.zyngier@arm.com> - 2017-04-25 11:20 +0200
                Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with  percpu irq request Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-25 12:00 +0200
                Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu  irq request Marc Zyngier <marc.zyngier@arm.com> - 2017-04-25 12:30 +0200
                Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with  percpu irq request Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-25 15:00 +0200
                Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu  irq request Marc Zyngier <marc.zyngier@arm.com> - 2017-04-25 15:30 +0200
                Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu  irq request Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-25 16:00 +0200
                Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with  percpu irq request Christoffer Dall <cdall@linaro.org> - 2017-04-25 12:30 +0200
                Re: [PATCH V9 1/3] irq: Allow to pass the IRQF_TIMER flag with  percpu irq request Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-25 15:00 +0200

csiph-web