Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629859

[HMM 02/15] mm/put_page: move ZONE_DEVICE page reference decrement v2

Show all headers | View raw

Move page reference decrement of ZONE_DEVICE from put_page()
to put_zone_device_page() this does not affect non ZONE_DEVICE
page.

Doing this allow to catch when a ZONE_DEVICE page refcount reach
1 which means the device is no longer reference by any one (unlike
page from other zone, ZONE_DEVICE page refcount never reach 0).

This patch is just a preparatory patch for HMM.

Changes since v1:
  - commit message

Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
---
 include/linux/mm.h | 14 +++++++++++---
 kernel/memremap.c  |  6 ++++++
 2 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index c82e8db..022423c 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -821,11 +821,19 @@ static inline void put_page(struct page *page)
 {
 	page = compound_head(page);
 
+	/*
+	 * ZONE_DEVICE pages should never have their refcount reach 0 (this
+	 * would be a bug), so call page_ref_dec() in put_zone_device_page()
+	 * to decrement page refcount and skip __put_page() here, as this
+	 * would worsen things if a ZONE_DEVICE had a refcount bug.
+	 */
+	if (unlikely(is_zone_device_page(page))) {
+		put_zone_device_page(page);
+		return;
+	}
+
 	if (put_page_testzero(page))
 		__put_page(page);
-
-	if (unlikely(is_zone_device_page(page)))
-		put_zone_device_page(page);
 }
 
 #if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP)
diff --git a/kernel/memremap.c b/kernel/memremap.c
index ea714ee..97ef676 100644
--- a/kernel/memremap.c
+++ b/kernel/memremap.c
@@ -190,6 +190,12 @@ EXPORT_SYMBOL(get_zone_device_page);
 
 void put_zone_device_page(struct page *page)
 {
+	/*
+	 * ZONE_DEVICE page refcount should never reach 0 and never be freed
+	 * to kernel memory allocator.
+	 */
+	page_ref_dec(page);
+
 	put_dev_pagemap(page->pgmap);
 }
 EXPORT_SYMBOL(put_zone_device_page);
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[HMM 00/15] HMM (Heterogeneous Memory Management) v21 Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200
  [HMM 03/15] mm/private-memory: new type of ZONE_DEVICE for unaddressable memory v2 Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200
  [HMM 01/15] mm, memory_hotplug: introduce add_pages Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200
  [HMM 11/15] mm/migrate: support un-addressable ZONE_DEVICE page in migration v2 Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200
  [HMM 04/15] mm/migrate: new migrate mode MIGRATE_SYNC_NO_COPY Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200
  [HMM 05/15] mm/migrate: new memory migration helper for use with device memory v4 Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200
  [HMM 14/15] mm/hmm/devmem: dummy HMM device for ZONE_DEVICE memory v3 Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200
  [HMM 02/15] mm/put_page: move ZONE_DEVICE page reference decrement v2 Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200
  [HMM 06/15] mm/migrate: migrate_vma() unmap page from vma while collecting pages Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200
  [HMM 15/15] hmm: heterogeneous memory management documentation Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200
  [HMM 07/15] mm/hmm: heterogeneous memory management (HMM for short) v3 Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200
  [HMM 13/15] mm/hmm/devmem: device memory hotplug using ZONE_DEVICE v4 Jérôme Glisse <jglisse@redhat.com> - 2017-04-24 20:20 +0200

csiph-web