Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629799

Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk

Show all headers | View raw

On Mon, Apr 24, 2017 at 08:02:10AM -0600, Shuah Khan wrote:
> On 04/22/2017 11:17 AM, priyalee.kushwaha@intel.com wrote:
> > From: Priyalee Kushwaha <priyalee.kushwaha@intel.com>
> > 
> > Most OS distribution have awk in /usr/bin not in /bin
> > Without this patch, kernel-devsrc fails to build as
> > runtime dependency for srcu-cbmc script /bin/awk is
> > not found.
> > 
> > Signed-off-by: Kushwaha, Priyalee <priyalee.kushwaha@intel.com>
> > ---
> >  tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> > index 8ff8904..c9e8bc5 100755
> > --- a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> > +++ b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> > @@ -1,4 +1,4 @@
> > -#!/bin/awk -f
> > +#!/usr/bin/awk -f
> >  
> >  # Modify SRCU for formal verification. The first argument should be srcu.h and
> >  # the second should be srcu.c. Outputs modified srcu.h and srcu.c into the
> > 
> 
> Hi Paul,
> 
> If this change looks good, please Ack it so I can take it through kselftest
> tree. If you would like to take this through rcu, that is fine as well.

Hello, Shuah,

I have queued it with Lance's ack and Josh's review.

Just for full disclosure, my recent SRCU work has broken srcu-cbmc,
and a bit more breakage is on its way.  :-(

That said, I would welcome patches to fix it -- mostly adjustments in
pathnames, structure names, and which fields get removed.  Adjusting it
to work correctly with Classic SRCU would probably be a bit easier than
adapting it to either Tree SRCU or Tiny SRCU.

							Thanx, Paul

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk priyalee.kushwaha@intel.com - 2017-04-21 20:30 +0200
  Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk Josh Triplett <josh@joshtriplett.org> - 2017-04-21 20:50 +0200
    RE: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk "Kushwaha, Priyalee" <priyalee.kushwaha@intel.com> - 2017-04-22 00:00 +0200
      Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk Josh Triplett <josh@joshtriplett.org> - 2017-04-22 00:10 +0200
        Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-24 04:50 +0200
          Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk Josh Triplett <josh@joshtriplett.org> - 2017-04-24 11:10 +0200
  Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-21 22:20 +0200
    Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk Lance Roy <ldr709@gmail.com> - 2017-04-24 05:30 +0200
      Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-24 05:40 +0200
  Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk Lance Roy <ldr709@gmail.com> - 2017-04-24 08:00 +0200
  Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk Shuah Khan <shuah@kernel.org> - 2017-04-24 16:10 +0200
    Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-24 19:10 +0200

csiph-web