[PATCH 1/2] f2fs: delay awaking discard thread

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Chao Yu <chao@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] f2fs: delay awaking discard thread
Date	Mon, 24 Apr 2017 18:30:01 +0200
Message-ID	<tzP29-Rd-1@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 2.12.2.575.gb14f27f
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu <yuchao0@huawei.com>
X-Original-Date	Tue, 25 Apr 2017 00:21:34 +0800
X-Original-Message-ID	<20170424162135.5566-1-chao@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1629755

Show key headers only | View raw

From: Chao Yu <yuchao0@huawei.com>

It's better to delay awaking discard thread while queuing discard commands
in checkpoint, it will help to give more chances for merging big and small
discard.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/segment.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index d4bda1e54475..8097b4c8c7c7 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -971,7 +971,6 @@ static int __queue_discard_cmd(struct f2fs_sb_info *sbi,
 		blkstart -= FDEV(devi).start_blk;
 	}
 	__update_discard_tree_range(sbi, bdev, lblkstart, blkstart, blklen);
-	wake_up(&SM_I(sbi)->dcc_info->discard_wait_queue);
 	return 0;
 }
 
@@ -1338,6 +1337,8 @@ void clear_prefree_segments(struct f2fs_sb_info *sbi, struct cp_control *cpc)
 		SM_I(sbi)->dcc_info->nr_discards -= total_len;
 		kmem_cache_free(discard_entry_slab, entry);
 	}
+
+	wake_up(&SM_I(sbi)->dcc_info->discard_wait_queue);
 }
 
 static int create_discard_cmd_control(struct f2fs_sb_info *sbi)
-- 
2.12.2.575.gb14f27f

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] f2fs: delay awaking discard thread Chao Yu <chao@kernel.org> - 2017-04-24 18:30 +0200
  [PATCH 2/2] f2fs: enable small discard by default Chao Yu <chao@kernel.org> - 2017-04-24 18:30 +0200

csiph-web