Re: [PATCH] qed: fix kzalloc-simple.cocci warnings

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] qed: fix kzalloc-simple.cocci warnings
Date	2017-04-24 18:10 +0200
Message-ID	<tzOIQ-JE-59@gated-at.bofh.it> (permalink)
References	<tyuCu-7kS-13@gated-at.bofh.it> <tyuCu-7kS-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: kbuild test robot <fengguang.wu@intel.com>
Date: Fri, 21 Apr 2017 08:20:07 +0800

> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1267:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset
> 
> 
>  Use kzalloc rather than kmalloc followed by memset with 0
> 
>  This considers some simple cases that are common and easy to validate
>  Note in particular that there are no ...s in the rule, so all of the
>  matched code has to be contiguous
> 
> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> 
> CC: sudarsana.kalluru@cavium.com <sudarsana.kalluru@cavium.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

I intentionally let this change happen.

It was less risky than asking the submitter who introduced it to
make another respin to keep the kzalloc().

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] qed: fix kzalloc-simple.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2017-04-21 02:30 +0200
  Re: [PATCH] qed: fix kzalloc-simple.cocci warnings David Miller <davem@davemloft.net> - 2017-04-24 18:10 +0200

csiph-web