Re: [PATCH 3/4] pinctrl: stm32: Implement .get_direction gpio_chip callback

From	Alexandre Torgue <alexandre.torgue@st.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] pinctrl: stm32: Implement .get_direction gpio_chip callback
Date	2017-04-24 18:10 +0200
Message-ID	<tzOIO-JE-11@gated-at.bofh.it> (permalink)
References	<ttDQ5-rS-9@gated-at.bofh.it> <ttDQ5-rS-7@gated-at.bofh.it> <tzLrB-6Zn-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Linus,

On 04/24/2017 02:37 PM, Linus Walleij wrote:
> On Fri, Apr 7, 2017 at 5:10 PM, Alexandre TORGUE
> <alexandre.torgue@st.com> wrote:
>
>> Add .get_direction() gpiochip callback in STM32 pinctrl driver.
>>
>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>
> (...)
>> +#include <linux/gpio.h>
>
> No this is wrong, drivers should never include this file.
> It is a deprecated consumer header.
>
>> +       if ((alt == 0) && (mode == 0))
>> +               ret = GPIOF_DIR_IN;
>> +       else if ((alt == 0) && (mode == 1))
>> +               ret = GPIOF_DIR_OUT;
>
> Just return 0 or 1, that is the driver-internal API.

Ok. I will fix it in V2.

Thanks
Alex

>
> Yours,
> Linus Walleij
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/4] pinctrl: stm32: Implement .get_direction gpio_chip callback Linus Walleij <linus.walleij@linaro.org> - 2017-04-24 14:40 +0200
  Re: [PATCH 3/4] pinctrl: stm32: Implement .get_direction gpio_chip  callback Alexandre Torgue <alexandre.torgue@st.com> - 2017-04-24 18:10 +0200

csiph-web