Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629615

[PATCH 1/9] crypto: add hmac IPAD/OPAD constant

Show all headers | View raw

Many HMAC users directly use directly 0x36/0x5c values.
It's better with crypto to use a name instead of directly some crypto
constant.

This patch simply add HMAC_IPAD_VALUE/HMAC_OPAD_VALUE defines.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 crypto/hmac.c         | 4 ++--
 include/crypto/hash.h | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/crypto/hmac.c b/crypto/hmac.c
index 72e38c0..4a997ce 100644
--- a/crypto/hmac.c
+++ b/crypto/hmac.c
@@ -74,8 +74,8 @@ static int hmac_setkey(struct crypto_shash *parent,
 	memcpy(opad, ipad, bs);
 
 	for (i = 0; i < bs; i++) {
-		ipad[i] ^= 0x36;
-		opad[i] ^= 0x5c;
+		ipad[i] ^= HMAC_IPAD_VALUE;
+		opad[i] ^= HMAC_OPAD_VALUE;
 	}
 
 	return crypto_shash_init(shash) ?:
diff --git a/include/crypto/hash.h b/include/crypto/hash.h
index b5727bc..0f51ff1 100644
--- a/include/crypto/hash.h
+++ b/include/crypto/hash.h
@@ -922,4 +922,7 @@ static inline void shash_desc_zero(struct shash_desc *desc)
 			 sizeof(*desc) + crypto_shash_descsize(desc->tfm));
 }
 
+#define HMAC_IPAD_VALUE 0x36
+#define HMAC_OPAD_VALUE 0x5c
+
 #endif	/* _CRYPTO_HASH_H */
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/9] crypto: add hmac IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-24 16:20 +0200
  [PATCH 4/9] crypto: marvell - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-24 16:30 +0200
  [PATCH 8/9] crypto: mediatek - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-24 16:30 +0200
  [PATCH 2/9] crypto: brcm - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-24 16:30 +0200
  [PATCH 7/9] crypto: qat - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-24 16:30 +0200
  [PATCH 9/9] crypto: ccp - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-24 16:30 +0200
  [PATCH 5/9] crypto: mv_cesa - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-24 16:30 +0200
  [PATCH 6/9] crypto: omap-sham - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-24 16:30 +0200

csiph-web