Re: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver
Date	2017-04-24 15:50 +0200
Message-ID	<tzMxj-7FA-9@gated-at.bofh.it> (permalink)
References	<tvKaK-1Dy-5@gated-at.bofh.it> <tvKaK-1Dy-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 13, 2017 at 12:27 PM, Nandor Han <nandor.han@ge.com> wrote:

> This is a simple driver that provides a /sys/class/gpio
> interface for controlling and configuring the GPIO lines.
> It does not provide support for chip select or interrupts.
>
> Signed-off-by: Nandor Han <nandor.han@ge.com>
> Signed-off-by: Semi Malinen <semi.malinen@ge.com>

I almost want to make the driver depend on !GPIO_SYSFS because
of this commit message.

DO NOT USE OR ENCOURAGE THE USE OF THE GPIO SYSFS
INTERFACE.

Use the character device.

Use the example in tools/gpio/* as a guideline and testbed.

Use libgpiod as a rich userspace.

And the commit message should state that this is a driver
for such and such Exar hardware instead.

Thanks.

> +#include <linux/bitops.h>
> +#include <linux/gpio/driver.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/of_device.h>
> +#include <linux/of_gpio.h>
> +#include <linux/spi/spi.h>
> +#include <linux/regmap.h>

You are missing
#include <linux/seq_file.h>

and that is why the build robot is complaining.

Yours,
Linus Walleij

Thread

[PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver Nandor Han <nandor.han@ge.com> - 2017-04-13 12:30 +0200
  Re: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver Linus Walleij <linus.walleij@linaro.org> - 2017-04-24 15:50 +0200
    [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver "Han, Nandor (GE Healthcare)" <nandor.han@ge.com> - 2017-04-24 16:00 +0200
    Re: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver Benjamin Henrion <zoobab@gmail.com> - 2017-04-25 09:10 +0200
      Re: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver Geert Uytterhoeven <geert@linux-m68k.org> - 2017-04-25 09:20 +0200
        Re: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-26 20:00 +0200
      Re: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver Linus Walleij <linus.walleij@linaro.org> - 2017-04-26 16:50 +0200

csiph-web