Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629511

Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten functions

Show all headers | View raw

On 04/23/2017 03:33 AM, Leon Romanovsky wrote:
> On Sat, Apr 22, 2017 at 04:36:19PM +0200, SF Markus Elfring wrote:
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Sat, 22 Apr 2017 13:26:49 +0200
>>
>> Replace the specification of data types by pointer dereferences
>> as the parameter for the operator "sizeof" to make the corresponding size
>> determinations a bit safer according to the Linux coding style convention.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>> ---
>>
>> v2:
>> Changes were rebased on source files from Linux next-20170421.
>> These were recombined as requested by Doug Ledford.
>
> Hi Doug,
>
> I recommend you to be extra cautious with this blind automatic
> conversions. It requires inspection that every size before and after
> match each other.
>
> I already asked it and would be like to repeat it. Please DON'T take any
> patches from Markus, which are related to mlx4/mlx5/rxe without our explicit
> review of them.

I agree with Leon here, and these sort of find/replace automagic 
clean-up patches make me nervous sometimes.

Markus, what have you done to ensure your patches don't break anything?

-Denny

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/12] InfiniBand-OCRDMA: Fine-tuning for several function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 16:30 +0200
  [PATCH v2 01/12] IB/ocrdma: Use kcalloc() in  ocrdma_mbx_alloc_pd_range() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 16:40 +0200
    Re: [PATCH v2 01/12] IB/ocrdma: Use kcalloc() in ocrdma_mbx_alloc_pd_range() Devesh Sharma <devesh.sharma@broadcom.com> - 2017-04-24 18:30 +0200
      Re: [PATCH v2 01/12] IB/ocrdma: Use kcalloc() in  ocrdma_mbx_alloc_pd_range() Doug Ledford <dledford@redhat.com> - 2017-04-25 19:10 +0200
  [PATCH v2 02/12] IB/ocrdma: Use kcalloc() in five functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 16:40 +0200
  [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 16:40 +0200
    Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten  functions Leon Romanovsky <leon@kernel.org> - 2017-04-23 09:40 +0200
      Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten  functions Dennis Dalessandro <dennis.dalessandro@intel.com> - 2017-04-24 15:00 +0200
        Re: IB/ocrdma: Improve size determinations in ten functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 15:30 +0200
          Re: IB/ocrdma: Improve size determinations in ten functions Leon Romanovsky <leon@kernel.org> - 2017-04-24 16:40 +0200
            Re: IB/ocrdma: Improve size determinations in ten functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 17:00 +0200
        Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten  functions Doug Ledford <dledford@redhat.com> - 2017-04-24 18:40 +0200
          Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten  functions Leon Romanovsky <leon@kernel.org> - 2017-04-24 20:10 +0200
      Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten  functions Doug Ledford <dledford@redhat.com> - 2017-04-24 18:40 +0200
  [PATCH v2 07/12] IB/ocrdma: Adjust 21 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 16:50 +0200
    Re: [PATCH v2 07/12] IB/ocrdma: Adjust 21 checks for null pointers Leon Romanovsky <leon@kernel.org> - 2017-04-23 08:10 +0200
  [PATCH v2 04/12] IB/ocrdma: Delete unnecessary variable  initialisations in ocrdma_mbx_get_dcbx_config() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 16:50 +0200
  [PATCH v2 08/12] IB/ocrdma: Delete an error message for a failed  memory allocation in ocrdma_add() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 16:50 +0200
  [PATCH v2 06/12] IB/ocrdma: Use kmalloc_array() in  ocrdma_create_srq() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 16:50 +0200
  [PATCH v2 05/12] IB/ocrdma: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 16:50 +0200
  [PATCH v2 11/12] IB/ocrdma: Delete an unnecessary variable in  ocrdma_dealloc_pd() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 17:00 +0200
  [PATCH v2 12/12] IB/ocrdma: One jump label less in  ocrdma_alloc_ucontext_pd() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 17:00 +0200
  [PATCH v2 09/12] IB/ocrdma: Delete an unnecessary variable assignment  in ocrdma_alloc_mr() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 17:00 +0200
  [PATCH v2 10/12] IB/ocrdma: Returning only value constants in  ocrdma_resize_cq() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-22 17:00 +0200

csiph-web