Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1629499
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt balancing logic |
| Date | 2017-04-24 14:50 +0200 |
| Message-ID | <tzLBg-72B-19@gated-at.bofh.it> (permalink) |
| References | <tyTrc-5zp-11@gated-at.bofh.it> <tzI0G-4Nd-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 24 Apr 2017 10:57:00 +0200 Peter Zijlstra <peterz@infradead.org> wrote: > On Fri, Apr 21, 2017 at 10:49:29PM -0400, Steven Rostedt wrote: > > +#ifdef HAVE_RT_PUSH_IPI > > + /* > > + * For IPI pull requests, loop across the rto_mask. > > + */ > > + struct irq_work rto_push_work; > > + raw_spinlock_t rto_lock; > > + /* These atomics are updated outside of a lock */ > > + atomic_t rto_loop_next; > > + atomic_t rto_loop_start; > > + /* These are only updated and read withn rto_lock */ > > + int rto_loop; > > + int rto_cpu; > > +#endif > > Don't you think it would make sense to place the rto_lock near the > variables it protects? And if those atomics are supposed to increase > performance, do they want to share the same cacheline with the lock? Good point! I'll update. -- Steve
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt balancing logic Steven Rostedt <rostedt@goodmis.org> - 2017-04-22 05:00 +0200
Re: [RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt balancing logic Steven Rostedt <rostedt@goodmis.org> - 2017-04-22 20:50 +0200
Re: [RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt balancing logic Peter Zijlstra <peterz@infradead.org> - 2017-04-24 11:00 +0200
Re: [RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt balancing logic Steven Rostedt <rostedt@goodmis.org> - 2017-04-24 14:50 +0200
Re: [RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt balancing logic Steven Rostedt <rostedt@goodmis.org> - 2017-04-24 14:50 +0200
Re: [RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt balancing logic Peter Zijlstra <peterz@infradead.org> - 2017-04-24 15:00 +0200
Re: [RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt balancing logic Steven Rostedt <rostedt@goodmis.org> - 2017-04-24 15:30 +0200
Re: [RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt balancing logic Peter Zijlstra <peterz@infradead.org> - 2017-04-24 16:00 +0200
Re: [RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt balancing logic Peter Zijlstra <peterz@infradead.org> - 2017-04-24 11:00 +0200
Re: [RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt balancing logic Steven Rostedt <rostedt@goodmis.org> - 2017-04-24 14:50 +0200
[PATCH RT v2] sched/rt: Simplify the IPI rt balancing logic Steven Rostedt <rostedt@goodmis.org> - 2017-04-24 18:00 +0200
csiph-web