Re: [PATCH v4] mfd: intel_soc_pmic: Fix a mess with compilation units

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] mfd: intel_soc_pmic: Fix a mess with compilation units
Date	2017-04-24 13:00 +0200
Message-ID	<tzJSN-5YI-7@gated-at.bofh.it> (permalink)
References	<tsvUC-4Rz-21@gated-at.bofh.it> <tv4uR-7Jp-9@gated-at.bofh.it> <txB3k-6zp-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 18 Apr 2017, Andy Shevchenko wrote:

> On Tue, 2017-04-11 at 14:54 +0100, Lee Jones wrote:
> > On Tue, 04 Apr 2017, Andy Shevchenko wrote:
> > 
> > > Crystal Cove and Whiskey Cove are two different PMICs which are
> > > installed on Intel Atom SoC based platforms.
> > > 
> > > Moreover there are two independent drivers that by some reason were
> > > supposed (*) to get into one kernel module.
> > > 
> > > Fix the mess by clarifying Kconfig option for Crystal Cove and split
> > > Whiskey Cove out of it.
> > > 
> > > (*) It looks like the configuration was never tested with
> > >     INTEL_SOC_PMIC=n. The line in Makefile is actually wrong.
> > > 
> > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> (supporter:ACPI)
> > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > > Acked-by: Zhang Rui <rui.zhang@intel.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >  - fix dependency for now, proper fix is to provide headers in
> > > platform_data/x86
> > >  - add tags
> > >  drivers/acpi/Kconfig         |  2 +-
> > >  drivers/gpio/Kconfig         |  2 +-
> > >  drivers/mfd/Kconfig          | 15 +++++++++++++--
> > >  drivers/mfd/Makefile         |  2 +-
> > >  drivers/platform/x86/Kconfig |  2 +-
> > >  drivers/thermal/Kconfig      |  2 +-
> > >  6 files changed, 18 insertions(+), 7 deletions(-)
> > 
> > Applied, thanks.
> 
> I didn't see it in next. Does it cause build issues still? I didn't get
> any report on it.

It's there now.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4] mfd: intel_soc_pmic: Fix a mess with compilation units Lee Jones <lee.jones@linaro.org> - 2017-04-11 16:00 +0200
  Re: [PATCH v4] mfd: intel_soc_pmic: Fix a mess with compilation  units Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-18 15:10 +0200
    Re: [PATCH v4] mfd: intel_soc_pmic: Fix a mess with compilation units Lee Jones <lee.jones@linaro.org> - 2017-04-24 13:00 +0200

csiph-web