Re: [PATCH V5 3/7] ARM: exynos: Use - instead of @ for DT OPP entries

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V5 3/7] ARM: exynos: Use - instead of @ for DT OPP entries
Date	2017-04-24 10:40 +0200
Message-ID	<tzHHk-4GC-7@gated-at.bofh.it> (permalink)
References	<tyhYB-7U2-3@gated-at.bofh.it> <tyhYB-7U2-1@gated-at.bofh.it> <tymYh-2Ig-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2017-04-21 1:09 GMT+09:00 Krzysztof Kozlowski <krzk@kernel.org>:
> On Thu, Apr 20, 2017 at 04:25:07PM +0530, Viresh Kumar wrote:
>> Compiling the DT file with W=1, DTC warns like follows:
>>
>> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
>> unit name, but no reg property
>>
>> Fix this by replacing '@' with '-' as the OPP nodes will never have a
>> "reg" property.
>>
>> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
>> Reported-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Suggested-by: Mark Rutland <mark.rutland@arm.com>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>>  .../devicetree/bindings/devfreq/exynos-bus.txt     | 46 +++++++--------
>>  arch/arm/boot/dts/exynos3250.dtsi                  | 46 +++++++--------
>>  arch/arm/boot/dts/exynos4210.dtsi                  | 32 +++++------
>>  arch/arm/boot/dts/exynos4412-prime.dtsi            |  4 +-
>>  arch/arm/boot/dts/exynos4412.dtsi                  | 66 +++++++++++-----------
>>  arch/arm/boot/dts/exynos5420.dtsi                  | 40 ++++++-------
>>  arch/arm/boot/dts/exynos5800.dtsi                  | 56 +++++++++---------
>>  arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi     | 48 ++++++++--------
>>  arch/arm64/boot/dts/exynos/exynos5433.dtsi         | 50 ++++++++--------
>>  9 files changed, 194 insertions(+), 194 deletions(-)
>
>
> Thanks, split ARM64 from ARM and applied (for v4.12). arm-soc keeps DTS
> separated between ARM architectures. Technically this should require a
> resend but we had way too many resends for this simple patch.
>


Minor note:

For arm64 part, Krzysztof's Signed-off-by is doubled.
(commit 5dccc9873c4af60f4478b3ef54267353f25cc301)






-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V5 3/7] ARM: exynos: Use - instead of @ for DT OPP entries Viresh Kumar <viresh.kumar@linaro.org> - 2017-04-20 13:00 +0200
  Re: [PATCH V5 3/7] ARM: exynos: Use - instead of @ for DT OPP entries Krzysztof Kozlowski <krzk@kernel.org> - 2017-04-20 18:20 +0200
    Re: [PATCH V5 3/7] ARM: exynos: Use - instead of @ for DT OPP entries Viresh Kumar <viresh.kumar@linaro.org> - 2017-04-21 07:30 +0200
    Re: [PATCH V5 3/7] ARM: exynos: Use - instead of @ for DT OPP entries Krzysztof Kozlowski <krzk@kernel.org> - 2017-04-24 10:40 +0200
    Re: [PATCH V5 3/7] ARM: exynos: Use - instead of @ for DT OPP entries Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-24 10:40 +0200

csiph-web