[PATCH 2/2] net: team: fix memory leak in team_nl_send_options_get

From	Pan Bian <bianpan2016@163.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] net: team: fix memory leak in team_nl_send_options_get
Date	2017-04-24 09:10 +0200
Message-ID	<tzGid-3VL-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

In function team_nl_send_options_get(), pointer skb keeps the return
value of function nlmsg_new(). When the call to genlmsg_put() fails, the
control flow directly returns and does not free skb. This will result in
a memory leak bug. This patch fixes it.

Fixes: 8ea7fd0d8792 ("team: fix memory leak")

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 drivers/net/team/team.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index dd3a2e9..85c0124 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -2361,8 +2361,10 @@ static int team_nl_send_options_get(struct team *team, u32 portid, u32 seq,
 
 	hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags | NLM_F_MULTI,
 			  TEAM_CMD_OPTIONS_GET);
-	if (!hdr)
+	if (!hdr) {
+		nlmsg_free(skb);
 		return -EMSGSIZE;
+	}
 
 	if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex))
 		goto nla_put_failure;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] net: team: fix memory leak in team_nl_send_options_get Pan Bian <bianpan2016@163.com> - 2017-04-24 09:10 +0200
  Re: [PATCH 2/2] net: team: fix memory leak in  team_nl_send_options_get Jiri Pirko <jiri@resnulli.us> - 2017-04-24 09:20 +0200

csiph-web