[PATCH 3/3] of: detect invalid phandle in overlay

From	frowand.list@gmail.com
Newsgroups	linux.kernel
Subject	[PATCH 3/3] of: detect invalid phandle in overlay
Date	2017-04-24 07:30 +0200
Message-ID	<tzEJr-2O1-9@gated-at.bofh.it> (permalink)
References	<tzEJr-2O1-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Frank Rowand <frank.rowand@sony.com>

Overlays are not allowed to modify phandle values of previously existing
nodes because there is no information available to allow fixup up of
properties that use the previously existing phandle.

Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
 drivers/of/overlay.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index 7827786718d8..c0e4ee1cd1ba 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -132,6 +132,10 @@ static int of_overlay_apply_single_device_node(struct of_overlay *ov,
 	/* NOTE: Multiple mods of created nodes not supported */
 	tchild = of_get_child_by_name(target, cname);
 	if (tchild != NULL) {
+		/* new overlay phandle value conflicts with existing value */
+		if (child->phandle)
+			return -EINVAL;
+
 		/* apply overlay recursively */
 		ret = of_overlay_apply_one(ov, tchild, child);
 		of_node_put(tchild);
-- 
Frank Rowand <frank.rowand@sony.com>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 3/3] of: detect invalid phandle in overlay frowand.list@gmail.com - 2017-04-24 07:30 +0200

csiph-web